[Libreoffice-commits] core.git: sc/qa sc/source sc/uiconfig

[Dennis Francis]

 sc/qa/uitest/statistics/data/regression.ods         |binary
 sc/source/ui/StatisticsDialogs/RegressionDialog.cxx |    2 +-
 sc/uiconfig/scalc/ui/regressiondialog.ui            |    9 ++++++++-
 3 files changed, 9 insertions(+), 2 deletions(-)

New commits:
commit 187af5be47db42e2f4ab94319f932b847f897ce2
Author: Dennis Francis <dennis.francis at collabora.co.uk>
Date:   Sun Jul 8 11:12:14 2018 +0530

    tdf#118556 : Respect locale specific decimal separator...
    
    in Regression dialog box's confidence-level entry.
    Do not write floating-point numbers to cells as strings using
    OUString::number() converter if the cell is supposed to be a
    numeric one.
    
    This also amends the uitest document such that the "expected"
    confidence level cell is numeric and not string.
    
    Thanks to Julien Nabet <serval2412 at yahoo.fr> for pointing me to
    the specific issue.
    
    Change-Id: I7d12674bf69fc53348366a03b7e6ff0af9588511
    Reviewed-on: https://gerrit.libreoffice.org/57151
    Tested-by: Jenkins
    Reviewed-by: Dennis Francis <dennis.francis at collabora.co.uk>

diff --git a/sc/qa/uitest/statistics/data/regression.ods b/sc/qa/uitest/statistics/data/regression.ods
index e38d0a7ab26b..f9f65bfda0f5 100644
Binary files a/sc/qa/uitest/statistics/data/regression.ods and b/sc/qa/uitest/statistics/data/regression.ods differ
diff --git a/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx b/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
index 086ef9b451cd..b3e744cdf71d 100644
--- a/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
+++ b/sc/source/ui/StatisticsDialogs/RegressionDialog.cxx
@@ -513,7 +513,7 @@ void ScRegressionDialog::WriteRegressionANOVAResults(AddressWalkerWriter& rOutpu
     rOutput.newLine();
     rOutput.writeString(ScResId(STR_LABEL_CONFIDENCE_LEVEL));
     rOutput.nextColumn();
-    rOutput.writeString(OUString::number(mpConfidenceLevelField->GetValue() / 100.0));
+    rOutput.writeValue(mpConfidenceLevelField->GetValue() / 100.0);
     rTemplate.autoReplaceAddress("%CONFIDENCE_LEVEL_ADDR%", rOutput.current());
     rOutput.newLine();
 }
diff --git a/sc/uiconfig/scalc/ui/regressiondialog.ui b/sc/uiconfig/scalc/ui/regressiondialog.ui
index 4ef37adfafdd..faa4aa307cfd 100644
--- a/sc/uiconfig/scalc/ui/regressiondialog.ui
+++ b/sc/uiconfig/scalc/ui/regressiondialog.ui
@@ -3,6 +3,12 @@
 <interface domain="sc">
   <requires lib="gtk+" version="3.18"/>
   <requires lib="LibreOffice" version="1.0"/>
+  <object class="GtkAdjustment" id="confidencelevel-adjustment">
+    <property name="upper">1</property>
+    <property name="value">0.94999999999999996</property>
+    <property name="step_increment">0.01</property>
+    <property name="page_increment">0.10000000000000001</property>
+  </object>
   <object class="GtkDialog" id="RegressionDialog">
     <property name="can_focus">False</property>
     <property name="border_width">6</property>
@@ -466,7 +472,8 @@
                         <property name="can_focus">True</property>
                         <property name="halign">start</property>
                         <property name="valign">center</property>
-                        <property name="text" translatable="yes" context="regressiondialog|confidencelevel-spin">0.95</property>
+                        <property name="text" context="regressiondialog|confidencelevel-spin">0,95</property>
+                        <property name="adjustment">confidencelevel-adjustment</property>
                         <property name="digits">2</property>
                         <property name="numeric">True</property>
                         <property name="value">0.94999999999999996</property>