[Libreoffice-commits] core.git: sc/qa

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sat Jul 14 06:15:58 UTC 2018


 sc/qa/extras/sctabviewobj.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 064c86b817c5d122af13f1bde26b51a992bf1fd9
Author:     Miklos Vajna <vmiklos at collabora.co.uk>
AuthorDate: Fri Jul 13 17:54:47 2018 +0200
Commit:     Miklos Vajna <vmiklos at collabora.co.uk>
CommitDate: Sat Jul 14 08:15:36 2018 +0200

    sc: disable sc_apitest::ScTabViewObj::testGetReferredCells()
    
    This was added in commit 600987b415e537362125b4445ab7132535e6e1e1
    (tdf#45904 Move remaining _XCellRangeReferrer Java tests to C++,
    2018-06-13), but as it was reported it fails on some Linux and Windows
    machines.
    
    Disable it till it's clear why that happens, as discussed at
    <https://lists.freedesktop.org/archives/libreoffice/2018-July/080521.html>.
    
    For the record, the failure what I can see is like this:
    
            xcellrangereferrer.cxx:32:Assertion
            Test name: sc_apitest::ScTabViewObj::testGetReferredCells
            equality assertion failed
            - Expected: Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 22
            - Actual  : Sheet: 0 StartColumn: 0 StartRow: 0 EndColumn: 6 EndRow: 23
    
            Failures !!!
            Run: 6   Failure total: 1   Failures: 1   Errors: 0
    
    Change-Id: I8057c938134b651b5f0f62fe07c2ef66a99d2e66
    Reviewed-on: https://gerrit.libreoffice.org/57396
    Tested-by: Jenkins
    Reviewed-by: Jens Carl <j.carl43 at gmx.de>

diff --git a/sc/qa/extras/sctabviewobj.cxx b/sc/qa/extras/sctabviewobj.cxx
index e8d9a8c8afd1..f4b54be64c7d 100644
--- a/sc/qa/extras/sctabviewobj.cxx
+++ b/sc/qa/extras/sctabviewobj.cxx
@@ -55,7 +55,8 @@ public:
     CPPUNIT_TEST(testAddRemoveActivationEventListener);
 
     // XCellRangeReferrer
-    CPPUNIT_TEST(testGetReferredCells);
+    //Disabled till it's clear why it fails on some machines.
+    //CPPUNIT_TEST(testGetReferredCells);
 
     // XSpreadsheetView
     CPPUNIT_TEST(testGetSetActiveSheet);


More information about the Libreoffice-commits mailing list