[Libreoffice-commits] core.git: 2 commits - oox/source sw/qa

[Libreoffice Gerrit user]

 oox/source/crypto/CryptTools.cxx      |    1 +
 sw/qa/extras/ww8export/ww8export2.cxx |    1 +
 2 files changed, 2 insertions(+)

New commits:
commit 0f84be3e0d26cf82af14bb07c71074c913cacbd7
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Jul 15 18:15:53 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Jul 15 22:08:57 2018 +0200

    coverity#1437957 Unchecked dynamic_cast
    
    Change-Id: I1c1d699e585da5d758671422f8e438e5ac8b5b03
    Reviewed-on: https://gerrit.libreoffice.org/57455
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sw/qa/extras/ww8export/ww8export2.cxx b/sw/qa/extras/ww8export/ww8export2.cxx
index c4d552393899..bea2891126df 100644
--- a/sw/qa/extras/ww8export/ww8export2.cxx
+++ b/sw/qa/extras/ww8export/ww8export2.cxx
@@ -318,6 +318,7 @@ DECLARE_WW8EXPORT_TEST(testTdf70838, "tdf70838.odt")
 DECLARE_WW8EXPORT_TEST(testTdf70838b_verticalRotation, "tdf70838b_verticalRotation.odt")
 {
     SwXTextDocument* pTextDoc = dynamic_cast<SwXTextDocument *>(mxComponent.get());
+    CPPUNIT_ASSERT(pTextDoc);
     SwDoc* pDoc = pTextDoc->GetDocShell()->GetDoc();
     SdrPage* pPage = pDoc->getIDocumentDrawModelAccess().GetDrawModel()->GetPage(0);
     tools::Rectangle aGroupShape = pPage->GetObj(0)->GetSnapRect();
commit ac52f29687a66f551d7e557a4486999e2ccd1b17
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Jul 15 18:14:31 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Jul 15 22:08:45 2018 +0200

    coverity#1437958 Uninitialized pointer field
    
    Change-Id: I569c4367cc968f968c0f864bb3e231a7417d7560
    Reviewed-on: https://gerrit.libreoffice.org/57454
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/oox/source/crypto/CryptTools.cxx b/oox/source/crypto/CryptTools.cxx
index d346fceb12fc..c507923f7bc9 100644
--- a/oox/source/crypto/CryptTools.cxx
+++ b/oox/source/crypto/CryptTools.cxx
@@ -134,6 +134,7 @@ struct CryptoImpl
         : mContext(nullptr)
         , mSecParam(nullptr)
         , mSymKey(nullptr)
+        , mpSlot(nullptr)
     {
         // Initialize NSS, database functions are not needed
         NSS_NoDB_Init(nullptr);