[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Jul 17 15:19:35 UTC 2018


 sc/source/filter/oox/workbookfragment.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit bd3baf8dab6c5b8865a33136cc28a016e6ee6afb
Author:     Eike Rathke <erack at redhat.com>
AuthorDate: Tue Jul 17 12:58:30 2018 +0200
Commit:     Eike Rathke <erack at redhat.com>
CommitDate: Tue Jul 17 17:19:13 2018 +0200

    OOXML import: CalcFormulaTree() is unnecessary, tdf#94925 follow-up
    
    View will trigger recalc of dirty cells, or anything else
    accessing formula cell results, so we can avoid a worst case full
    blown recalc.
    
    Change-Id: Ic94c3520358a817614ec730f3471368303e34d2e
    Reviewed-on: https://gerrit.libreoffice.org/57551
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Eike Rathke <erack at redhat.com>

diff --git a/sc/source/filter/oox/workbookfragment.cxx b/sc/source/filter/oox/workbookfragment.cxx
index 330dcb073b2d..162fb3812201 100644
--- a/sc/source/filter/oox/workbookfragment.cxx
+++ b/sc/source/filter/oox/workbookfragment.cxx
@@ -579,7 +579,9 @@ void WorkbookFragment::recalcFormulaCells()
     else
     {
         getDocImport().broadcastRecalcAfterImport();
-        rDoc.CalcFormulaTree(false, true, false);
+        // Full ScDocument::CalcFormulaTree() of all dirty cells is not
+        // necessary here, the View will recalculate them in the visible area,
+        // or any other method accessing formula cell results.
     }
 }
 


More information about the Libreoffice-commits mailing list