[Libreoffice-commits] core.git: configure.ac

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Jul 18 08:44:34 UTC 2018


 configure.ac |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 13d0b53fe4030f0be7bd176a2934548f57bff729
Author:     Vasily Melenchuk <vasily.melenchuk at cib.de>
AuthorDate: Wed Jul 18 02:00:18 2018 +0300
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Wed Jul 18 10:44:12 2018 +0200

    configure: diagnose and report cygpath convert failure
    
    If Windows machine has short filenames disabled,
    it is not reported during configure run, but leads
    to unexpected and difficult to understand failures
    later. Checking of cygpath call conversion result
    should help to diagnose this problem earlier.
    
    Change-Id: Ia93ae612f4bc624bc3e71c6733838fd14b075f64
    Reviewed-on: https://gerrit.libreoffice.org/57608
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/configure.ac b/configure.ac
index 2fd11a9b3d19..7308d31faebd 100644
--- a/configure.ac
+++ b/configure.ac
@@ -81,6 +81,10 @@ PathFormat()
                 AC_MSG_ERROR([path conversion failed for "$1".])
             fi
         fi
+        fp_count_space=`echo "$formatted_path" | $GREP -c "[ ]"`
+        if test "$fp_count_space" != "0"; then
+            AC_MSG_ERROR([converted path "$formatted_path" still contains spaces. Short filenames (8.3 filenames) support was disabled on this system?])
+        fi
     fi
 }
 


More information about the Libreoffice-commits mailing list