[Libreoffice-commits] core.git: Branch 'libreoffice-6-0' - sfx2/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Jul 23 17:29:16 UTC 2018


 sfx2/source/doc/objxtor.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit d4052d2ca523cc000132620aaecb59c14c17e20d
Author:     Markus Mohrhard <markus.mohrhard at googlemail.com>
AuthorDate: Sat Jul 21 01:57:27 2018 +0200
Commit:     Michael Meeks <michael.meeks at collabora.com>
CommitDate: Mon Jul 23 19:28:56 2018 +0200

    fix shutdown crash when SfxApplication has already been destroyed
    
    See e.g. http://crashreport.libreoffice.org/stats/crash_details/dc1ae6ff-923e-44f6-99a9-84893039efd7
    
    Change-Id: I3b5a24bfb62977ca922bf3bececb6676691bf6ea
    Reviewed-on: https://gerrit.libreoffice.org/57789
    Tested-by: Jenkins
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    (cherry picked from commit 715fcaff01ed048c52c69264a7a0fb773dd57b32)
    Reviewed-on: https://gerrit.libreoffice.org/57809
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

diff --git a/sfx2/source/doc/objxtor.cxx b/sfx2/source/doc/objxtor.cxx
index 959666dfcc74..e1a130c7fc79 100644
--- a/sfx2/source/doc/objxtor.cxx
+++ b/sfx2/source/doc/objxtor.cxx
@@ -314,13 +314,13 @@ SfxObjectShell::~SfxObjectShell()
     DELETEX(AutoReloadTimer_Impl, pImpl->pReloadTimer );
 
     SfxApplication *pSfxApp = SfxGetpApp();
-    if ( USHRT_MAX != pImpl->nVisualDocumentNumber )
+    if ( USHRT_MAX != pImpl->nVisualDocumentNumber && pSfxApp )
         pSfxApp->ReleaseIndex(pImpl->nVisualDocumentNumber);
 
     // Destroy Basic-Manager
     pImpl->aBasicManager.reset( nullptr );
 
-    if ( pSfxApp->GetDdeService() )
+    if ( pSfxApp && pSfxApp->GetDdeService() )
         pSfxApp->RemoveDdeTopic( this );
 
     pImpl->pBaseModel.set( nullptr );


More information about the Libreoffice-commits mailing list