[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - svx/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Jul 25 22:50:06 UTC 2018


 svx/source/form/datanavi.cxx |    4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

New commits:
commit 9b18192fc3af465fb424dd8d5a81cd46fc3331b6
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Jul 25 10:18:56 2018 +0100
Commit:     Eike Rathke <erack at redhat.com>
CommitDate: Thu Jul 26 00:49:54 2018 +0200

    Resolves: tdf#118862 new instances cannot be edited
    
    Change-Id: I9b10ff4f043949c7140852ac9ad9106ca611c98c
    Reviewed-on: https://gerrit.libreoffice.org/57961
    Tested-by: Jenkins
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/svx/source/form/datanavi.cxx b/svx/source/form/datanavi.cxx
index 2446606e373d..bb4732cd945c 100644
--- a/svx/source/form/datanavi.cxx
+++ b/svx/source/form/datanavi.cxx
@@ -1760,7 +1760,7 @@ namespace svxform
 
     bool DataNavigatorWindow::IsAdditionalPage(sal_uInt16 nId) const
     {
-        return m_pTabCtrl->GetPagePos(nId) >= 3;
+        return m_pTabCtrl->GetPageName(nId).isEmpty();
     }
 
     IMPL_LINK( DataNavigatorWindow, MenuActivateHdl, MenuButton *, pBtn, void )
@@ -1914,8 +1914,10 @@ namespace svxform
                 XFormsPage* pPage = GetCurrentPage( nId );
                 DBG_ASSERT( pPage, "DataNavigatorWindow::SetPageModel(): no page" );
                 if (IsAdditionalPage(nId) || m_pTabCtrl->GetPageName(nId) == "instance")
+                {
                     // instance page
                     nPagePos = m_pTabCtrl->GetPagePos( nId );
+                }
                 m_bIsNotifyDisabled = true;
                 OUString sText = pPage->SetModel( xFormsModel, nPagePos );
                 m_bIsNotifyDisabled = false;


More information about the Libreoffice-commits mailing list