[Libreoffice-commits] core.git: basic/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Jul 26 14:27:54 UTC 2018


 basic/source/comp/scanner.cxx |    3 ---
 basic/source/comp/token.cxx   |    5 -----
 basic/source/inc/scanner.hxx  |    1 -
 basic/source/inc/token.hxx    |    1 -
 4 files changed, 10 deletions(-)

New commits:
commit e6ab9174b02aa6240ed9c4392a0e1b0c261d3481
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Jul 26 11:56:40 2018 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Jul 26 16:27:20 2018 +0200

    basic: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)
    
    ...by removing explicitly user-provided functions that do the same as their
    implicitly-defined counterparts, but may prevent implicitly declared copy
    functions from being defined as non-deleted in the future.  (Even if a dtor was
    declared non-inline in an include file, the apparently-used implicitly-defined
    copy functions are already inline, so why bother with a non-inline dtor.)
    
    Change-Id: I8a31ab0c806cb0f3c226d217f152a205aff6c07f
    Reviewed-on: https://gerrit.libreoffice.org/58065
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/basic/source/comp/scanner.cxx b/basic/source/comp/scanner.cxx
index fe6263a39f90..821f231aea20 100644
--- a/basic/source/comp/scanner.cxx
+++ b/basic/source/comp/scanner.cxx
@@ -53,9 +53,6 @@ SbiScanner::SbiScanner( const OUString& rBuf, StarBASIC* p ) : aBuf( rBuf )
     nSaveLineIdx = -1;
 }
 
-SbiScanner::~SbiScanner()
-{}
-
 void SbiScanner::LockColumn()
 {
     if( !nColLock++ )
diff --git a/basic/source/comp/token.cxx b/basic/source/comp/token.cxx
index 4cb564d0b62e..3b6d81416fc0 100644
--- a/basic/source/comp/token.cxx
+++ b/basic/source/comp/token.cxx
@@ -217,11 +217,6 @@ SbiTokenizer::SbiTokenizer( const OUString& rSrc, StarBASIC* pb )
 {
 }
 
-SbiTokenizer::~SbiTokenizer()
-{
-}
-
-
 void SbiTokenizer::Push( SbiToken t )
 {
     if( ePush != NIL )
diff --git a/basic/source/inc/scanner.hxx b/basic/source/inc/scanner.hxx
index b0b0b00590f7..5b5b03653b3b 100644
--- a/basic/source/inc/scanner.hxx
+++ b/basic/source/inc/scanner.hxx
@@ -67,7 +67,6 @@ protected:
     void   GenError( ErrCode );
 public:
     SbiScanner( const OUString&, StarBASIC* = nullptr );
-   ~SbiScanner();
 
     void  EnableErrors()            { bError = false; }
     bool  IsHash()                  { return bHash;   }
diff --git a/basic/source/inc/token.hxx b/basic/source/inc/token.hxx
index 598d20c15e42..fd991ba1bb6e 100644
--- a/basic/source/inc/token.hxx
+++ b/basic/source/inc/token.hxx
@@ -111,7 +111,6 @@ protected:
     bool bErrorIsSymbol;            // Handle Error token as Symbol, not keyword
 public:
     SbiTokenizer( const OUString&, StarBASIC* = nullptr );
-   ~SbiTokenizer();
 
     bool IsEof()             { return bEof; }
     bool IsEos()             { return bEos; }


More information about the Libreoffice-commits mailing list