[Libreoffice-commits] core.git: comphelper/source include/comphelper

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Jul 26 18:40:33 UTC 2018


 comphelper/source/misc/logging.cxx |    6 ------
 include/comphelper/logging.hxx     |    2 --
 2 files changed, 8 deletions(-)

New commits:
commit 74da5c2914876cb2b1d4cc0e898d6bab0c99fb98
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Jul 26 11:47:03 2018 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Jul 26 20:40:03 2018 +0200

    comphelper: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)
    
    ...by removing explicitly user-provided functions that do the same as their
    implicitly-defined counterparts, but may prevent implicitly declared copy
    functions from being defined as non-deleted in the future.  (Even if a dtor was
    declared non-inline in an include file, the apparently-used implicitly-defined
    copy functions are already inline, so why bother with a non-inline dtor.)
    
    Change-Id: Id5494686dd169b17de7830588e603d1fd5f6b768
    Reviewed-on: https://gerrit.libreoffice.org/58061
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/comphelper/source/misc/logging.cxx b/comphelper/source/misc/logging.cxx
index c6863539a116..5b6c6bc6fda2 100644
--- a/comphelper/source/misc/logging.cxx
+++ b/comphelper/source/misc/logging.cxx
@@ -72,12 +72,6 @@ namespace comphelper
     {
     }
 
-
-    EventLogger::~EventLogger()
-    {
-    }
-
-
     bool EventLogger::isLoggable( const sal_Int32 _nLogLevel ) const
     {
         if ( !m_pImpl->isValid() )
diff --git a/include/comphelper/logging.hxx b/include/comphelper/logging.hxx
index 69d6c9a354ec..fd04e83f732d 100644
--- a/include/comphelper/logging.hxx
+++ b/include/comphelper/logging.hxx
@@ -108,8 +108,6 @@ namespace comphelper
             const sal_Char* _pAsciiLoggerName
         );
 
-        ~EventLogger();
-
     public:
         /// determines whether an event with the given level would be logged
         bool        isLoggable( const sal_Int32 _nLogLevel ) const;


More information about the Libreoffice-commits mailing list