[Libreoffice-commits] online.git: wsd/FileServer.cpp wsd/FileServer.hpp

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Jul 31 07:19:22 UTC 2018


 wsd/FileServer.cpp |    4 ++--
 wsd/FileServer.hpp |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

New commits:
commit 6f3fd44c037a8da64cc8f1c5fd7af6c7424e2e6c
Author:     Miklos Vajna <vmiklos at collabora.co.uk>
AuthorDate: Tue Jul 31 09:18:52 2018 +0200
Commit:     Miklos Vajna <vmiklos at collabora.co.uk>
CommitDate: Tue Jul 31 09:19:03 2018 +0200

    wsd: make these a const reference instead of copying for each invocation

diff --git a/wsd/FileServer.cpp b/wsd/FileServer.cpp
index 6b7ba63bd..4bf3e4cb6 100644
--- a/wsd/FileServer.cpp
+++ b/wsd/FileServer.cpp
@@ -431,8 +431,8 @@ void FileServerRequestHandler::handleRequest(const HTTPRequest& request, Poco::M
 
 void FileServerRequestHandler::sendError(int errorCode, const Poco::Net::HTTPRequest& request,
                                          const std::shared_ptr<StreamSocket>& socket,
-                                         std::string shortMessage, std::string longMessage,
-                                         std::string extraHeader)
+                                         const std::string& shortMessage, const std::string& longMessage,
+                                         const std::string& extraHeader)
 {
     Poco::URI requestUri(request.getURI());
     std::string path(requestUri.getPath());
diff --git a/wsd/FileServer.hpp b/wsd/FileServer.hpp
index 62647b4c0..b415eed65 100644
--- a/wsd/FileServer.hpp
+++ b/wsd/FileServer.hpp
@@ -43,8 +43,8 @@ public:
 private:
     static std::map<std::string, std::pair<std::string, std::string>> FileHash;
     static void sendError(int errorCode, const Poco::Net::HTTPRequest& request,
-                          const std::shared_ptr<StreamSocket>& socket, std::string shortMessage,
-                          std::string longMessage, std::string extraHeader = "");
+                          const std::shared_ptr<StreamSocket>& socket, const std::string& shortMessage,
+                          const std::string& longMessage, const std::string& extraHeader = "");
 };
 
 #endif


More information about the Libreoffice-commits mailing list