[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml

Gabor Kelemen kelemeng at ubuntu.com
Mon Jun 4 06:34:19 UTC 2018


 sc/IwyuFilter_sc.yaml            |    6 ++++++
 sc/inc/rangeseq.hxx              |    5 ++++-
 sc/inc/rangeutl.hxx              |    9 +++------
 sc/inc/rechead.hxx               |    2 --
 sc/inc/refdata.hxx               |    1 -
 sc/inc/refreshtimerprotector.hxx |    1 +
 sc/inc/reftokenhelper.hxx        |    6 ++++--
 sc/inc/rowheightcontext.hxx      |    2 --
 8 files changed, 18 insertions(+), 14 deletions(-)

New commits:
commit 620315e0cb230b6e6922920c6e0e7bb25386cce6
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Tue May 15 07:11:19 2018 +0200

    tdf#42949 Fix IWYU warnings in sc/inc/r*
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here
    and a bit of fallout management
    
    Change-Id: I5dd272c6c5fa305113f4446ed49c130c6c007146
    Reviewed-on: https://gerrit.libreoffice.org/55096
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 47346286fea1..3e934749e154 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -192,3 +192,9 @@ blacklist:
     - com/sun/star/container/XNameAccess.hpp
     - com/sun/star/lang/XServiceInfo.hpp
     - cppuhelper/supportsservice.hxx
+    sc/inc/reftokenhelper.hxx:
+    # base class has to be a complete type
+    - refdata.hxx
+    sc/inc/rowheightcontext.hxx:
+    # base class has to be a complete type
+    - vcl/outdev.hxx
diff --git a/sc/inc/rangeseq.hxx b/sc/inc/rangeseq.hxx
index dc8ce018dd64..6b532aed75ca 100644
--- a/sc/inc/rangeseq.hxx
+++ b/sc/inc/rangeseq.hxx
@@ -20,11 +20,14 @@
 #ifndef INCLUDED_SC_INC_RANGESEQ_HXX
 #define INCLUDED_SC_INC_RANGESEQ_HXX
 
-#include <com/sun/star/uno/Any.h>
 #include "types.hxx"
+#include <com/sun/star/uno/TypeClass.hpp>
+
+namespace com { namespace sun { namespace star { namespace uno { class Any; } } } }
 
 class SvNumberFormatter;
 class ScDocument;
+class ScMatrix;
 class ScRange;
 
 class ScRangeToSequence
diff --git a/sc/inc/rangeutl.hxx b/sc/inc/rangeutl.hxx
index 68c930221ca7..e65213f848db 100644
--- a/sc/inc/rangeutl.hxx
+++ b/sc/inc/rangeutl.hxx
@@ -25,16 +25,13 @@
 #include "dbdata.hxx"
 #include "scdllapi.h"
 
-#include <com/sun/star/table/CellAddress.hpp>
-#include <com/sun/star/table/CellRangeAddress.hpp>
-#include <com/sun/star/uno/Sequence.hxx>
+namespace com { namespace sun { namespace star { namespace table { struct CellAddress; } } } }
+namespace com { namespace sun { namespace star { namespace table { struct CellRangeAddress; } } } }
+namespace com { namespace sun { namespace star { namespace uno { template <typename > class Sequence; } } } }
 
 class ScArea;
 class ScDocument;
-class ScRange;
-class ScRangeName;
 class ScRangeList;
-class ScDBCollection;
 
 enum RutlNameScope { RUTL_NONE=0, RUTL_NAMES, RUTL_DBASE };
 
diff --git a/sc/inc/rechead.hxx b/sc/inc/rechead.hxx
index c6839e750b80..6f90c218bdbb 100644
--- a/sc/inc/rechead.hxx
+++ b/sc/inc/rechead.hxx
@@ -43,8 +43,6 @@
 // btw: 10 following 09 is not a counting error but an intentional gap,
 // because it was not clear, how long the RelRefs development would take. :)
 
-class SvStream;
-
         //  Header with size specification for multiple objects
 
 class ScMultipleReadHeader
diff --git a/sc/inc/refdata.hxx b/sc/inc/refdata.hxx
index 8a7cc81b67e0..7edac9f4bb01 100644
--- a/sc/inc/refdata.hxx
+++ b/sc/inc/refdata.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_SC_INC_REFDATA_HXX
 #define INCLUDED_SC_INC_REFDATA_HXX
 
-#include "global.hxx"
 #include "address.hxx"
 #include "scdllapi.h"
 #include "calcmacros.hxx"
diff --git a/sc/inc/refreshtimerprotector.hxx b/sc/inc/refreshtimerprotector.hxx
index 9a4f41b6e209..9fcb50421096 100644
--- a/sc/inc/refreshtimerprotector.hxx
+++ b/sc/inc/refreshtimerprotector.hxx
@@ -12,6 +12,7 @@
 
 #include <sal/config.h>
 #include "scdllapi.h"
+#include <memory>
 
 class ScRefreshTimerControl;
 
diff --git a/sc/inc/reftokenhelper.hxx b/sc/inc/reftokenhelper.hxx
index 0ce3336db8c2..cf71b2309bad 100644
--- a/sc/inc/reftokenhelper.hxx
+++ b/sc/inc/reftokenhelper.hxx
@@ -20,13 +20,15 @@
 #ifndef INCLUDED_SC_INC_REFTOKENHELPER_HXX
 #define INCLUDED_SC_INC_REFTOKENHELPER_HXX
 
-#include "token.hxx"
+#include "address.hxx"
+#include "types.hxx"
+#include "scdllapi.h"
 
 #include <vector>
 
 class ScDocument;
-class ScRange;
 class ScRangeList;
+struct ScComplexRefData;
 
 namespace ScRefTokenHelper
 {
diff --git a/sc/inc/rowheightcontext.hxx b/sc/inc/rowheightcontext.hxx
index d1a8f8ff68e4..78bee982744e 100644
--- a/sc/inc/rowheightcontext.hxx
+++ b/sc/inc/rowheightcontext.hxx
@@ -16,8 +16,6 @@
 #include <vcl/vclptr.hxx>
 #include <vcl/outdev.hxx>
 
-#include <vector>
-
 #include "segmenttree.hxx"
 
 namespace sc {


More information about the Libreoffice-commits mailing list