[Libreoffice-commits] online.git: common/Seccomp.cpp PROBLEMS

[Tor Lillqvist]

 PROBLEMS           |    2 --
 common/Seccomp.cpp |    8 ++------
 2 files changed, 2 insertions(+), 8 deletions(-)

New commits:
commit 72baaa231c87f8f71cb0ad60acef848f9c05b237
Author: Tor Lillqvist <tml at collabora.com>
Date:   Fri Jun 8 08:42:31 2018 +0300

    We seemed to have just two minor ASCII art instances, actually
    
    Change-Id: I308cda537c26b1a9976e7bcf7634c67917a30163

diff --git a/PROBLEMS b/PROBLEMS
index 1e8a1f66a..e044f5d8f 100644
--- a/PROBLEMS
+++ b/PROBLEMS
@@ -51,5 +51,3 @@
   used just once or twice, passed as a parameter to a function, or
   used in a comparisin expression. This is fairly pointless and just
   makes the code harder to read. Use string literals instead.
-
-- ASCII art? Seriously?
diff --git a/common/Seccomp.cpp b/common/Seccomp.cpp
index fc276a8aa..e65e8b4ac 100644
--- a/common/Seccomp.cpp
+++ b/common/Seccomp.cpp
@@ -101,9 +101,7 @@ bool lockdown(Type type)
         // Load sycall number
         BPF_STMT(BPF_LD+BPF_W+BPF_ABS,  offsetof(struct seccomp_data, nr)),
 
-        // ------------------------------------------------------------
-        // ---   First white-list the syscalls we frequently use.   ---
-        // ------------------------------------------------------------
+        // First white-list the syscalls we frequently use.
         ACCEPT_SYSCALL(recvfrom),
         ACCEPT_SYSCALL(write),
         ACCEPT_SYSCALL(futex),
@@ -115,9 +113,7 @@ bool lockdown(Type type)
         ACCEPT_SYSCALL(close),
         ACCEPT_SYSCALL(nanosleep),
 
-        // ------------------------------------------------------------
-        // --- Now block everything that we don't like the look of. ---
-        // ------------------------------------------------------------
+        // Now block everything that we don't like the look of.
 
         // FIXME: should we bother blocking calls that have early
         // permission checks we don't meet ?