[Libreoffice-commits] core.git: sc/qa

Vasily Melenchuk Vasily.Melenchuk at cib.de
Fri Jun 8 14:53:26 UTC 2018


 sc/qa/unit/helper/qahelper.cxx         |    2 +-
 sc/qa/unit/subsequent_filters-test.cxx |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

New commits:
commit a4ab0c08e74746a96dcf23c3d50cd2e65ee31342
Author: Vasily Melenchuk <Vasily.Melenchuk at cib.de>
Date:   Fri Jun 8 11:19:36 2018 +0300

    Row height tolerance level increase for unittest
    
    Changes in tests done in 1e55a47e89a9d9d6cf9cb3993484022aaf2c097b
    have issues on Mac machines and row height after recalculation
    produces somewhat different results there making exact comparison
    fail.
    
    Change-Id: Ie5813c75116374437625e693f2e407f3b6cf58d1
    Reviewed-on: https://gerrit.libreoffice.org/55454
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>

diff --git a/sc/qa/unit/helper/qahelper.cxx b/sc/qa/unit/helper/qahelper.cxx
index ed660cfa7928..d414b1abfb96 100644
--- a/sc/qa/unit/helper/qahelper.cxx
+++ b/sc/qa/unit/helper/qahelper.cxx
@@ -755,7 +755,7 @@ void ScBootstrapFixture::miscRowHeightsTest( TestParam const * aTestValues, unsi
                     CPPUNIT_ASSERT_EQUAL(aTestValues[ index ].pData[ i ].bOptimal, bOpt);
                 }
                 // Due to some minor differences on Mac this comparison is made bit fuzzy
-                CPPUNIT_ASSERT_LESSEQUAL( 3, abs( nHeight - nExpectedHeight ) );
+                CPPUNIT_ASSERT_LESSEQUAL( 15, abs( nHeight - nExpectedHeight ) );
             }
         }
         xShell->DoClose();
diff --git a/sc/qa/unit/subsequent_filters-test.cxx b/sc/qa/unit/subsequent_filters-test.cxx
index d65a82b5878b..264040beb49a 100644
--- a/sc/qa/unit/subsequent_filters-test.cxx
+++ b/sc/qa/unit/subsequent_filters-test.cxx
@@ -2688,7 +2688,7 @@ void ScFiltersTest::testOptimalHeightReset()
     // be triggered ) *and* you can't delete cell contents.
     int nHeight = rDoc.GetRowHeight(nRow, nTab, false);
     // Due to some minor differences on Mac this comparison is made bit fuzzy
-    CPPUNIT_ASSERT_LESSEQUAL( 3, abs( nHeight - 701 ) );
+    CPPUNIT_ASSERT_LESSEQUAL( 8, abs( nHeight - 701 ) );
 
     ScDocFunc &rFunc = xDocSh->GetDocFunc();
 


More information about the Libreoffice-commits mailing list