[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

[Gabor Kelemen]

 sc/IwyuFilter_sc.yaml                          |   19 +++++++++++++++++++
 sc/inc/PivotTableDataProvider.hxx              |   17 ++++++++---------
 sc/inc/PivotTableDataSequence.hxx              |    5 +----
 sc/inc/PivotTableDataSource.hxx                |    5 ++---
 sc/source/ui/unoobj/PivotTableDataSequence.cxx |    1 +
 5 files changed, 31 insertions(+), 16 deletions(-)

New commits:
commit af625c8b7143bef6d2d61037427f9934607f336f
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Wed Jun 13 22:06:33 2018 +0200

    tdf#42949 Fix IWYU warnings in sc/inc/P*
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: Ic46d80186b0eb69e7bd8553278ffc9043b9b4bef
    Reviewed-on: https://gerrit.libreoffice.org/55768
    Tested-by: Jenkins
    Reviewed-by: Jochen Nitschke <j.nitschke+logerrit at ok.de>

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index e2a2829c862d..03aafba301b6 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -197,6 +197,25 @@ blacklist:
     - com/sun/star/container/XNameAccess.hpp
     - com/sun/star/lang/XServiceInfo.hpp
     - cppuhelper/supportsservice.hxx
+    sc/inc/PivotTableDataSequence.hxx:
+    # base class has to be a complete type
+    - com/sun/star/beans/XPropertySet.hpp
+    - com/sun/star/chart2/data/DataSequenceRole.hpp
+    - com/sun/star/chart2/data/XDataSequence.hpp
+    - com/sun/star/chart2/data/XDataSequence.hpp
+    - com/sun/star/chart2/data/XNumericalDataSequence.hpp
+    - com/sun/star/chart2/data/XTextualDataSequence.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/util/XCloneable.hpp
+    - com/sun/star/util/XModifyBroadcaster.hpp
+    sc/inc/PivotTableDataProvider.hxx:
+    # base class has to be a complete type
+    - com/sun/star/beans/XPropertySet.hpp
+    - com/sun/star/chart2/data/PivotTableFieldEntry.hpp
+    - com/sun/star/chart2/data/XDataProvider.hpp
+    - com/sun/star/chart2/data/XPivotTableDataProvider.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/util/XModifyBroadcaster.hpp
     sc/inc/reftokenhelper.hxx:
     # base class has to be a complete type
     - refdata.hxx
diff --git a/sc/inc/PivotTableDataProvider.hxx b/sc/inc/PivotTableDataProvider.hxx
index b1924753ece3..1403dfdad3d2 100644
--- a/sc/inc/PivotTableDataProvider.hxx
+++ b/sc/inc/PivotTableDataProvider.hxx
@@ -10,19 +10,11 @@
 #ifndef INCLUDED_SC_INC_PIVOTTABLEDATAPROVIDER_HXX
 #define INCLUDED_SC_INC_PIVOTTABLEDATAPROVIDER_HXX
 
-#include "cellsuno.hxx"
-#include "externalrefmgr.hxx"
-#include "types.hxx"
-
 #include <com/sun/star/chart2/data/XDataProvider.hpp>
 #include <com/sun/star/chart2/data/XPivotTableDataProvider.hpp>
-#include <com/sun/star/chart2/data/XDataSource.hpp>
-#include <com/sun/star/chart2/data/XDataSequence.hpp>
-#include <com/sun/star/chart2/data/XLabeledDataSequence.hpp>
 #include <com/sun/star/chart2/data/PivotTableFieldEntry.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
 #include <com/sun/star/beans/XPropertySet.hpp>
-#include <com/sun/star/util/XCloneable.hpp>
 #include <com/sun/star/util/XModifyBroadcaster.hpp>
 
 #include <svl/lstner.hxx>
@@ -30,8 +22,15 @@
 #include <rtl/ustring.hxx>
 #include <svl/itemprop.hxx>
 
-#include <memory>
 #include <vector>
+#include <unordered_map>
+
+namespace com { namespace sun { namespace star { namespace chart2 { namespace data { class XDataSequence; } } } } }
+namespace com { namespace sun { namespace star { namespace chart2 { namespace data { class XDataSource; } } } } }
+namespace com { namespace sun { namespace star { namespace chart2 { namespace data { class XLabeledDataSequence; } } } } }
+namespace com { namespace sun { namespace star { namespace uno { class XComponentContext; } } } }
+
+class ScDocument;
 
 namespace sc
 {
diff --git a/sc/inc/PivotTableDataSequence.hxx b/sc/inc/PivotTableDataSequence.hxx
index 470a7a5b2f0c..8448edcc5a9e 100644
--- a/sc/inc/PivotTableDataSequence.hxx
+++ b/sc/inc/PivotTableDataSequence.hxx
@@ -25,10 +25,7 @@
 #include <cppuhelper/implbase.hxx>
 #include <rtl/math.hxx>
 
-#include "unonames.hxx"
-#include "document.hxx"
-
-#include "dpsave.hxx"
+class ScDocument;
 
 namespace sc
 {
diff --git a/sc/inc/PivotTableDataSource.hxx b/sc/inc/PivotTableDataSource.hxx
index e6eda8be6c75..a98f977cc0ec 100644
--- a/sc/inc/PivotTableDataSource.hxx
+++ b/sc/inc/PivotTableDataSource.hxx
@@ -15,10 +15,9 @@
 
 #include <svl/lstner.hxx>
 #include <cppuhelper/implbase.hxx>
+#include <vector>
 
-#include "document.hxx"
-
-#include <com/sun/star/chart2/data/LabeledDataSequence.hpp>
+namespace com { namespace sun { namespace star { namespace chart2 { namespace data { class XLabeledDataSequence; } } } } }
 
 namespace sc
 {
diff --git a/sc/source/ui/unoobj/PivotTableDataSequence.cxx b/sc/source/ui/unoobj/PivotTableDataSequence.cxx
index ee14b9b85f2f..7cfc609c6512 100644
--- a/sc/source/ui/unoobj/PivotTableDataSequence.cxx
+++ b/sc/source/ui/unoobj/PivotTableDataSequence.cxx
@@ -16,6 +16,7 @@
 #include <document.hxx>
 #include <docsh.hxx>
 #include <hints.hxx>
+#include <unonames.hxx>
 
 #include <com/sun/star/chart/ChartDataChangeEvent.hpp>