[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

Gabor Kelemen kelemeng at ubuntu.com
Wed Jun 20 12:29:08 UTC 2018 

 sc/IwyuFilter_sc.yaml                |    7 +++++++
 sc/inc/undorangename.hxx             |    1 -
 sc/inc/userdat.hxx                   |    2 --
 sc/inc/validat.hxx                   |    1 -
 sc/inc/viewopti.hxx                  |    1 -
 sc/inc/viewuno.hxx                   |    5 +++--
 sc/inc/xmlwrap.hxx                   |    7 ++-----
 sc/source/core/data/documen3.cxx     |    1 +
 sc/source/core/data/validat.cxx      |    1 +
 sc/source/filter/excel/impop.cxx     |    1 +
 sc/source/filter/excel/xecontent.cxx |    1 +
 sc/source/filter/excel/xicontent.cxx |    1 +
 sc/source/ui/dbgui/validate.cxx      |    1 +
 sc/source/ui/view/cellsh2.cxx        |    1 +
 sc/source/ui/view/gridwin.cxx        |    1 +
 15 files changed, 20 insertions(+), 12 deletions(-)

New commits:
commit 3efc2d022b0d1a5cf6155257d57504d47ceefc44
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Sat May 19 09:22:07 2018 +0200

    tdf#42949 Fix IWYU warnings in sc/inc/[ux]*
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here
    and a bit of fallout management
    
    Change-Id: I53d2c5dc9e16a64a143b16316d2aeab05023d866
    Reviewed-on: https://gerrit.libreoffice.org/56076
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index 166b76fbd66b..5011ecdea951 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -208,6 +208,10 @@ blacklist:
     - com/sun/star/lang/XServiceInfo.hpp
     - com/sun/star/util/XCloneable.hpp
     - com/sun/star/util/XModifyBroadcaster.hpp
+    sc/inc/PivotTableDataSource.hxx:
+    # base class has to be a complete type
+    - com/sun/star/chart2/data/XDataSource.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
     sc/inc/PivotTableDataProvider.hxx:
     # base class has to be a complete type
     - com/sun/star/beans/XPropertySet.hpp
@@ -287,3 +291,6 @@ blacklist:
     sc/inc/types.hxx:
     # base class has to be a complete type
     - o3tl/typed_flags_set.hxx
+    sc/inc/unitconv.hxx:
+    # base class has to be a complete type
+    - map
diff --git a/sc/inc/undorangename.hxx b/sc/inc/undorangename.hxx
index 46b4075eb7f0..2ad874c2ab96 100644
--- a/sc/inc/undorangename.hxx
+++ b/sc/inc/undorangename.hxx
@@ -11,7 +11,6 @@
 #define INCLUDED_SC_INC_UNDORANGENAME_HXX
 
 #include <undobase.hxx>
-#include "rangenam.hxx"
 
 #include <memory>
 #include <map>
diff --git a/sc/inc/userdat.hxx b/sc/inc/userdat.hxx
index 8b1b1cee9e77..a85c5b3d8946 100644
--- a/sc/inc/userdat.hxx
+++ b/sc/inc/userdat.hxx
@@ -21,9 +21,7 @@
 #define INCLUDED_SC_INC_USERDAT_HXX
 
 #include <svx/svdobj.hxx>
-#include <tools/link.hxx>
 #include <svtools/imap.hxx>
-#include "global.hxx"
 #include "address.hxx"
 #include "drwlayer.hxx"
 
diff --git a/sc/inc/validat.hxx b/sc/inc/validat.hxx
index 92e87901fc9d..a451a999a659 100644
--- a/sc/inc/validat.hxx
+++ b/sc/inc/validat.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_SC_INC_VALIDAT_HXX
 
 #include "conditio.hxx"
-#include <com/sun/star/sheet/TableValidationVisibility.hpp>
 #include "scdllapi.h"
 
 namespace vcl { class Window; }
diff --git a/sc/inc/viewopti.hxx b/sc/inc/viewopti.hxx
index 8bc3d380b28a..cd73ada6640e 100644
--- a/sc/inc/viewopti.hxx
+++ b/sc/inc/viewopti.hxx
@@ -22,7 +22,6 @@
 
 #include <svx/optgrid.hxx>
 
-#include <svx/svxids.hrc>
 #include "scdllapi.h"
 #include "optutil.hxx"
 #include "global.hxx"
diff --git a/sc/inc/viewuno.hxx b/sc/inc/viewuno.hxx
index 839219677d4b..f9328fb87d95 100644
--- a/sc/inc/viewuno.hxx
+++ b/sc/inc/viewuno.hxx
@@ -23,7 +23,6 @@
 #include <sfx2/sfxbasecontroller.hxx>
 #include <svl/itemprop.hxx>
 #include <com/sun/star/view/XFormLayerAccess.hpp>
-#include <com/sun/star/view/XSelectionChangeListener.hpp>
 #include <com/sun/star/view/XSelectionSupplier.hpp>
 #include <com/sun/star/sheet/XCellRangeReferrer.hpp>
 #include <com/sun/star/sheet/XViewSplitable.hpp>
@@ -40,7 +39,9 @@
 #include <com/sun/star/lang/XUnoTunnel.hpp>
 #include <com/sun/star/datatransfer/XTransferableSupplier.hpp>
 
-#include "address.hxx"
+#include "types.hxx"
+
+namespace com { namespace sun { namespace star { namespace view { class XSelectionChangeListener; } } } }
 
 class ScTabViewShell;
 class ScPreviewShell;
diff --git a/sc/inc/xmlwrap.hxx b/sc/inc/xmlwrap.hxx
index 0d3e79432c97..3327160b45c0 100644
--- a/sc/inc/xmlwrap.hxx
+++ b/sc/inc/xmlwrap.hxx
@@ -21,10 +21,7 @@
 #define INCLUDED_SC_INC_XMLWRAP_HXX
 
 #include <com/sun/star/uno/Reference.hxx>
-#include <com/sun/star/uno/Sequence.hxx>
-#include <com/sun/star/frame/XModel.hpp>
 #include "importfilterdata.hxx"
-#include <sal/types.h>
 
 #include <vcl/errcode.hxx>
 
@@ -32,8 +29,8 @@ namespace com { namespace sun { namespace star {
     namespace beans { struct PropertyValue; }
     namespace frame { class XModel; }
     namespace task { class XStatusIndicator; }
-    namespace lang { class XMultiServiceFactory; }
-    namespace uno { class XInterface; }
+    namespace uno { class XComponentContext; }
+    namespace uno { template <class E> class Sequence; }
     namespace embed { class XStorage; }
     namespace xml {
         namespace sax { struct InputSource; class XParser; class XWriter; } }
diff --git a/sc/source/core/data/documen3.cxx b/sc/source/core/data/documen3.cxx
index cda718468f97..21d11f94d95c 100644
--- a/sc/source/core/data/documen3.cxx
+++ b/sc/source/core/data/documen3.cxx
@@ -18,6 +18,7 @@
  */
 
 #include <com/sun/star/script/vba/XVBAEventProcessor.hpp>
+#include <com/sun/star/sheet/TableValidationVisibility.hpp>
 #include <scitems.hxx>
 #include <editeng/langitem.hxx>
 #include <svl/srchitem.hxx>
diff --git a/sc/source/core/data/validat.cxx b/sc/source/core/data/validat.cxx
index 813c9940ff9f..97c9effbb954 100644
--- a/sc/source/core/data/validat.cxx
+++ b/sc/source/core/data/validat.cxx
@@ -20,6 +20,7 @@
 #include <config_features.h>
 
 #include <validat.hxx>
+#include <com/sun/star/sheet/TableValidationVisibility.hpp>
 
 #include <sfx2/app.hxx>
 #include <sfx2/docfile.hxx>
diff --git a/sc/source/filter/excel/impop.cxx b/sc/source/filter/excel/impop.cxx
index 44585254d753..d01fe225c805 100644
--- a/sc/source/filter/excel/impop.cxx
+++ b/sc/source/filter/excel/impop.cxx
@@ -34,6 +34,7 @@
 #include <sfx2/printer.hxx>
 #include <sfx2/docfile.hxx>
 #include <svx/pageitem.hxx>
+#include <svx/svxids.hrc>
 #include <svl/zforlist.hxx>
 #include <unotools/configmgr.hxx>
 
diff --git a/sc/source/filter/excel/xecontent.cxx b/sc/source/filter/excel/xecontent.cxx
index 8cd7de4b5066..deb8f8dd2454 100644
--- a/sc/source/filter/excel/xecontent.cxx
+++ b/sc/source/filter/excel/xecontent.cxx
@@ -24,6 +24,7 @@
 #include <algorithm>
 #include <com/sun/star/sheet/XAreaLinks.hpp>
 #include <com/sun/star/sheet/XAreaLink.hpp>
+#include <com/sun/star/sheet/TableValidationVisibility.hpp>
 #include <comphelper/string.hxx>
 #include <sfx2/objsh.hxx>
 #include <tools/urlobj.hxx>
diff --git a/sc/source/filter/excel/xicontent.cxx b/sc/source/filter/excel/xicontent.cxx
index 2ee892c287e2..dce417adea3a 100644
--- a/sc/source/filter/excel/xicontent.cxx
+++ b/sc/source/filter/excel/xicontent.cxx
@@ -17,6 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include <com/sun/star/sheet/TableValidationVisibility.hpp>
 #include <xicontent.hxx>
 #include <sfx2/objsh.hxx>
 #include <sfx2/docfile.hxx>
diff --git a/sc/source/ui/dbgui/validate.cxx b/sc/source/ui/dbgui/validate.cxx
index 99c5b05132ea..fe6bd005f669 100644
--- a/sc/source/ui/dbgui/validate.cxx
+++ b/sc/source/ui/dbgui/validate.cxx
@@ -21,6 +21,7 @@
 #undef SC_DLLIMPLEMENTATION
 #endif
 
+#include <com/sun/star/sheet/TableValidationVisibility.hpp>
 #include <comphelper/string.hxx>
 #include <vcl/svapp.hxx>
 #include <vcl/builderfactory.hxx>
diff --git a/sc/source/ui/view/cellsh2.cxx b/sc/source/ui/view/cellsh2.cxx
index 52588c005dda..59d2466d420a 100644
--- a/sc/source/ui/view/cellsh2.cxx
+++ b/sc/source/ui/view/cellsh2.cxx
@@ -36,6 +36,7 @@
 
 #include <com/sun/star/frame/FrameSearchFlag.hpp>
 #include <com/sun/star/sdbc/XResultSet.hpp>
+#include <com/sun/star/sheet/TableValidationVisibility.hpp>
 
 #include <cellsh.hxx>
 #include <tabvwsh.hxx>
diff --git a/sc/source/ui/view/gridwin.cxx b/sc/source/ui/view/gridwin.cxx
index d0769177b395..a159d448b726 100644
--- a/sc/source/ui/view/gridwin.cxx
+++ b/sc/source/ui/view/gridwin.cxx
@@ -62,6 +62,7 @@
 #include <com/sun/star/sheet/DataPilotTablePositionData.hpp>
 #include <com/sun/star/sheet/DataPilotTablePositionType.hpp>
 #include <com/sun/star/sheet/MemberResultFlags.hpp>
+#include <com/sun/star/sheet/TableValidationVisibility.hpp>
 #include <com/sun/star/awt/KeyModifier.hpp>
 #include <com/sun/star/awt/MouseButton.hpp>
 #include <com/sun/star/script/vba/VBAEventId.hpp>

More information about the Libreoffice-commits mailing list