[Libreoffice-commits] core.git: sc/source

Eike Rathke erack at redhat.com
Wed Jun 20 21:28:36 UTC 2018


 sc/source/core/data/formulacell.cxx |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit 00b3007976f60bdf65fbe69e3f4f1613b477a059
Author: Eike Rathke <erack at redhat.com>
Date:   Wed Jun 20 19:31:36 2018 +0200

    Avoid side effects of additional Interpret() during iteration
    
    ... which could alter results if this formula cell again depends
    on other formula cells in the circular reference(s).
    
    Change-Id: I2b56902a71c0f16f9777507402ea004ae609bfbc
    Reviewed-on: https://gerrit.libreoffice.org/56182
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Eike Rathke <erack at redhat.com>

diff --git a/sc/source/core/data/formulacell.cxx b/sc/source/core/data/formulacell.cxx
index 615dccfce416..661b0940eaf6 100644
--- a/sc/source/core/data/formulacell.cxx
+++ b/sc/source/core/data/formulacell.cxx
@@ -2598,6 +2598,11 @@ bool ScFormulaCell::IsMultilineResult()
 
 bool ScFormulaCell::NeedsInterpret() const
 {
+    if (bIsIterCell)
+        // Shortcut to force return of current value and not enter Interpret()
+        // as we're looping over all iteration cells.
+        return false;
+
     if (!IsDirtyOrInTableOpDirty())
         return false;
 


More information about the Libreoffice-commits mailing list