[Libreoffice-commits] core.git: include/IwyuFilter_include.yaml include/sal opencl/inc scaddins/source sccomp/source xmloff/source

Gabor Kelemen kelemeng at ubuntu.com
Fri Jun 22 07:06:57 UTC 2018


 include/IwyuFilter_include.yaml       |   10 ++++++++++
 include/sal/mathconf.h                |    2 --
 opencl/inc/opencl_device_selection.h  |    1 +
 scaddins/source/analysis/analysis.cxx |    1 +
 sccomp/source/solver/CoinMPSolver.cxx |    1 +
 xmloff/source/style/xmlnumfe.cxx      |    1 +
 6 files changed, 14 insertions(+), 2 deletions(-)

New commits:
commit f3a2a20311c5ad383754a9fbb90d611863562e02
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Mon Jun 18 21:59:42 2018 +0200

    tdf#42949 Fix IWYU warnings in include/sal/
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: I62758fd7c9d932c5a390739774b112356006a937
    Reviewed-on: https://gerrit.libreoffice.org/56062
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/include/IwyuFilter_include.yaml b/include/IwyuFilter_include.yaml
index 2398dc61771f..184c9680648c 100644
--- a/include/IwyuFilter_include.yaml
+++ b/include/IwyuFilter_include.yaml
@@ -1,2 +1,12 @@
 ---
 assumeFilename: desktop/source/app/app.cxx
+blacklist:
+    include/sal/typesizes.h:
+    # needed for build to work
+    - config_typesizes.h
+    include/sal/types.h:
+    # needed for build to work
+    - sal/typesizes.h
+    include/sal/mathconf.h:
+    # Platform dependent
+    - cmath
diff --git a/include/sal/mathconf.h b/include/sal/mathconf.h
index 6232bcc10f2a..687f6e3da133 100644
--- a/include/sal/mathconf.h
+++ b/include/sal/mathconf.h
@@ -22,8 +22,6 @@
 
 #include "osl/endian.h"
 
-#include <float.h>
-
 #if defined __sun
 #include <ieeefp.h>
 #endif /* __sun */
diff --git a/opencl/inc/opencl_device_selection.h b/opencl/inc/opencl_device_selection.h
index 8849cd59abbc..9786dc5adfdc 100644
--- a/opencl/inc/opencl_device_selection.h
+++ b/opencl/inc/opencl_device_selection.h
@@ -16,6 +16,7 @@
 
 #include <memory>
 
+#include <float.h>
 #include <stdlib.h>
 #include <stdio.h>
 #include <string.h>
diff --git a/scaddins/source/analysis/analysis.cxx b/scaddins/source/analysis/analysis.cxx
index 34414abd0f50..cb2a8b3dd04f 100644
--- a/scaddins/source/analysis/analysis.cxx
+++ b/scaddins/source/analysis/analysis.cxx
@@ -32,6 +32,7 @@
 #include <unotools/resmgr.hxx>
 #include <algorithm>
 #include <cmath>
+#include <float.h>
 
 #define ADDIN_SERVICE               "com.sun.star.sheet.AddIn"
 #define MY_SERVICE                  "com.sun.star.sheet.addin.Analysis"
diff --git a/sccomp/source/solver/CoinMPSolver.cxx b/sccomp/source/solver/CoinMPSolver.cxx
index 6f840a6edabe..2b1ddd7227d7 100644
--- a/sccomp/source/solver/CoinMPSolver.cxx
+++ b/sccomp/source/solver/CoinMPSolver.cxx
@@ -30,6 +30,7 @@
 #include <rtl/math.hxx>
 #include <stdexcept>
 #include <vector>
+#include <float.h>
 
 using namespace com::sun::star;
 
diff --git a/xmloff/source/style/xmlnumfe.cxx b/xmloff/source/style/xmlnumfe.cxx
index 7001328ab196..52847a6a8784 100644
--- a/xmloff/source/style/xmlnumfe.cxx
+++ b/xmloff/source/style/xmlnumfe.cxx
@@ -45,6 +45,7 @@
 #include <xmloff/xmltoken.hxx>
 #include <xmloff/xmlexp.hxx>
 
+#include <float.h>
 #include <set>
 #include <vector>
 


More information about the Libreoffice-commits mailing list