[Libreoffice-commits] core.git: sd/IwyuFilter_sd.yaml sd/source

Gabor Kelemen kelemeng at ubuntu.com
Fri Jun 22 19:13:12 UTC 2018 

 sd/IwyuFilter_sd.yaml                   |    3 +++
 sd/source/core/drawdoc3.cxx             |    1 +
 sd/source/ui/app/sddll.cxx              |    1 +
 sd/source/ui/func/fuconcs.cxx           |    1 +
 sd/source/ui/func/fuconuno.cxx          |    1 +
 sd/source/ui/func/fuinsfil.cxx          |    1 +
 sd/source/ui/func/fupage.cxx            |    1 +
 sd/source/ui/func/fusel.cxx             |    1 +
 sd/source/ui/inc/GraphicDocShell.hxx    |    1 -
 sd/source/ui/inc/GraphicObjectBar.hxx   |    1 -
 sd/source/ui/inc/fuconcs.hxx            |    2 +-
 sd/source/ui/inc/fuconrec.hxx           |    1 -
 sd/source/ui/inc/fuconstr.hxx           |    1 -
 sd/source/ui/inc/fuconuno.hxx           |    2 +-
 sd/source/ui/inc/fuformatpaintbrush.hxx |    3 ---
 sd/source/ui/inc/fuinsert.hxx           |    1 -
 sd/source/ui/inc/fuinsfil.hxx           |    1 +
 sd/source/ui/inc/fumorph.hxx            |    1 -
 sd/source/ui/inc/fupage.hxx             |    1 +
 sd/source/ui/inc/fupoor.hxx             |    7 +++++--
 sd/source/ui/inc/fusel.hxx              |    2 +-
 sd/source/ui/inc/futext.hxx             |    3 +--
 sd/source/ui/inc/futransf.hxx           |    1 -
 sd/source/ui/inc/headerfooterdlg.hxx    |    1 -
 24 files changed, 21 insertions(+), 18 deletions(-)

New commits:
commit c1738429b08f9d0a614ff5ee7090fd8ea41fc67a
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Sun Jun 10 21:12:02 2018 +0200

    tdf#42949 Fix IWYU warnings in sd/source/ui/inc/[f-h]*
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: Ie93b7695e4c67fc55089b21a5df37a3468ad4bee
    Reviewed-on: https://gerrit.libreoffice.org/55565
    Tested-by: Jenkins
    Reviewed-by: Jochen Nitschke <j.nitschke+logerrit at ok.de>

diff --git a/sd/IwyuFilter_sd.yaml b/sd/IwyuFilter_sd.yaml
index 7fa7e749560c..9729c1b65af8 100644
--- a/sd/IwyuFilter_sd.yaml
+++ b/sd/IwyuFilter_sd.yaml
@@ -122,3 +122,6 @@ blacklist:
     - com/sun/star/view/XFormLayerAccess.hpp
     - com/sun/star/view/XSelectionSupplier.hpp
     - sfx2/sfxbasecontroller.hxx
+    sd/source/ui/inc/fupage.hxx:
+    # base class has to be a complete type
+    - vcl/weld.hxx
\ No newline at end of file
diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx
index 9be0f79798f2..51c56bc886f5 100644
--- a/sd/source/core/drawdoc3.cxx
+++ b/sd/source/core/drawdoc3.cxx
@@ -41,6 +41,7 @@
 
 #include <strings.hrc>
 #include <drawdoc.hxx>
+#include <sdmod.hxx>
 #include <sdpage.hxx>
 #include <stlpool.hxx>
 #include <sdresid.hxx>
diff --git a/sd/source/ui/app/sddll.cxx b/sd/source/ui/app/sddll.cxx
index 072702db97d7..a84e6b8bde96 100644
--- a/sd/source/ui/app/sddll.cxx
+++ b/sd/source/ui/app/sddll.cxx
@@ -95,6 +95,7 @@
 #include <vcl/FilterConfigItem.hxx>
 #include <o3tl/make_unique.hxx>
 #include <sdabstdlg.hxx>
+#include <sdmod.hxx>
 
 using namespace ::com::sun::star;
 
diff --git a/sd/source/ui/func/fuconcs.cxx b/sd/source/ui/func/fuconcs.cxx
index a8d5f929fb77..d0133674fc29 100644
--- a/sd/source/ui/func/fuconcs.cxx
+++ b/sd/source/ui/func/fuconcs.cxx
@@ -18,6 +18,7 @@
  */
 
 #include <fuconcs.hxx>
+#include <rtl/ustring.hxx>
 #include <svx/svdpagv.hxx>
 
 #include <svx/svxids.hrc>
diff --git a/sd/source/ui/func/fuconuno.cxx b/sd/source/ui/func/fuconuno.cxx
index 8ff99fdb7e00..ca9f9c8eed80 100644
--- a/sd/source/ui/func/fuconuno.cxx
+++ b/sd/source/ui/func/fuconuno.cxx
@@ -18,6 +18,7 @@
  */
 
 #include <fuconuno.hxx>
+#include <rtl/ustring.hxx>
 #include <svl/aeitem.hxx>
 #include <sfx2/dispatch.hxx>
 #include <sfx2/viewfrm.hxx>
diff --git a/sd/source/ui/func/fuinsfil.cxx b/sd/source/ui/func/fuinsfil.cxx
index b041615a63d9..f57a8556137a 100644
--- a/sd/source/ui/func/fuinsfil.cxx
+++ b/sd/source/ui/func/fuinsfil.cxx
@@ -51,6 +51,7 @@
 #include <View.hxx>
 #include <strings.hrc>
 #include <stlpool.hxx>
+#include <sdmod.hxx>
 #include <sdpage.hxx>
 #include <strmname.h>
 #include <ViewShellBase.hxx>
diff --git a/sd/source/ui/func/fupage.cxx b/sd/source/ui/func/fupage.cxx
index 5c2c79847df7..aba72b39782e 100644
--- a/sd/source/ui/func/fupage.cxx
+++ b/sd/source/ui/func/fupage.cxx
@@ -50,6 +50,7 @@
 #include <editeng/pbinitem.hxx>
 #include <sfx2/app.hxx>
 #include <sfx2/opengrf.hxx>
+#include <rtl/ustring.hxx>
 
 #include <strings.hrc>
 #include <sdpage.hxx>
diff --git a/sd/source/ui/func/fusel.cxx b/sd/source/ui/func/fusel.cxx
index ea56b9e4d756..84fcea47cbec 100644
--- a/sd/source/ui/func/fusel.cxx
+++ b/sd/source/ui/func/fusel.cxx
@@ -19,6 +19,7 @@
 
 #include <config_features.h>
 
+#include <com/sun/star/media/XPlayer.hpp>
 #include <fusel.hxx>
 #include <basic/sbstar.hxx>
 #include <svx/svddrgmt.hxx>
diff --git a/sd/source/ui/inc/GraphicDocShell.hxx b/sd/source/ui/inc/GraphicDocShell.hxx
index 51130fafa563..9406a127a262 100644
--- a/sd/source/ui/inc/GraphicDocShell.hxx
+++ b/sd/source/ui/inc/GraphicDocShell.hxx
@@ -24,7 +24,6 @@
 #include <sfx2/objsh.hxx>
 #include "DrawDocShell.hxx"
 #include <glob.hxx>
-#include <sdmod.hxx>
 #include <pres.hxx>
 
 namespace sd {
diff --git a/sd/source/ui/inc/GraphicObjectBar.hxx b/sd/source/ui/inc/GraphicObjectBar.hxx
index 76c560c49224..48d59cbd1f7a 100644
--- a/sd/source/ui/inc/GraphicObjectBar.hxx
+++ b/sd/source/ui/inc/GraphicObjectBar.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_SD_SOURCE_UI_INC_GRAPHICOBJECTBAR_HXX
 #define INCLUDED_SD_SOURCE_UI_INC_GRAPHICOBJECTBAR_HXX
 
-#include <sfx2/module.hxx>
 #include <sfx2/shell.hxx>
 #include <glob.hxx>
 
diff --git a/sd/source/ui/inc/fuconcs.hxx b/sd/source/ui/inc/fuconcs.hxx
index 0d54581fecf0..a66ee13aad0c 100644
--- a/sd/source/ui/inc/fuconcs.hxx
+++ b/sd/source/ui/inc/fuconcs.hxx
@@ -21,8 +21,8 @@
 #define INCLUDED_SD_SOURCE_UI_INC_FUCONCS_HXX
 
 #include "fuconstr.hxx"
+#include <rtl/ustring.hxx>
 
-class KeyEvent;
 class SdDrawDocument;
 class SdrObject;
 
diff --git a/sd/source/ui/inc/fuconrec.hxx b/sd/source/ui/inc/fuconrec.hxx
index 68aa8466efb3..0de3e237e591 100644
--- a/sd/source/ui/inc/fuconrec.hxx
+++ b/sd/source/ui/inc/fuconrec.hxx
@@ -22,7 +22,6 @@
 
 #include "fuconstr.hxx"
 
-class KeyEvent;
 class SdDrawDocument;
 class SdrObject;
 class SfxItemSet;
diff --git a/sd/source/ui/inc/fuconstr.hxx b/sd/source/ui/inc/fuconstr.hxx
index 91cb1e7e0c1f..6f40e6150ca0 100644
--- a/sd/source/ui/inc/fuconstr.hxx
+++ b/sd/source/ui/inc/fuconstr.hxx
@@ -22,7 +22,6 @@
 
 #include "fudraw.hxx"
 
-class KeyEvent;
 class SdrObject;
 class SfxItemSet;
 
diff --git a/sd/source/ui/inc/fuconuno.hxx b/sd/source/ui/inc/fuconuno.hxx
index fa337df75d71..248f8c60da84 100644
--- a/sd/source/ui/inc/fuconuno.hxx
+++ b/sd/source/ui/inc/fuconuno.hxx
@@ -20,8 +20,8 @@
 #ifndef INCLUDED_SD_SOURCE_UI_INC_FUCONUNO_HXX
 #define INCLUDED_SD_SOURCE_UI_INC_FUCONUNO_HXX
 
-#include <svl/itemset.hxx>
 #include "fuconstr.hxx"
+#include <rtl/ustring.hxx>
 
 enum class SdrInventor : sal_uInt32;
 
diff --git a/sd/source/ui/inc/fuformatpaintbrush.hxx b/sd/source/ui/inc/fuformatpaintbrush.hxx
index 043b4ef207b2..a4596dfbbb3d 100644
--- a/sd/source/ui/inc/fuformatpaintbrush.hxx
+++ b/sd/source/ui/inc/fuformatpaintbrush.hxx
@@ -22,9 +22,6 @@
 
 #include "futext.hxx"
 
-#include <svl/itemset.hxx>
-#include <memory>
-
 namespace sd {
 
 class DrawViewShell;
diff --git a/sd/source/ui/inc/fuinsert.hxx b/sd/source/ui/inc/fuinsert.hxx
index 21ec76d78f60..2f599fa7fd07 100644
--- a/sd/source/ui/inc/fuinsert.hxx
+++ b/sd/source/ui/inc/fuinsert.hxx
@@ -21,7 +21,6 @@
 #define INCLUDED_SD_SOURCE_UI_INC_FUINSERT_HXX
 
 #include "fupoor.hxx"
-#include <config_features.h>
 
 namespace sd {
 
diff --git a/sd/source/ui/inc/fuinsfil.hxx b/sd/source/ui/inc/fuinsfil.hxx
index 6a4fa1930e2e..5e239ded6ec8 100644
--- a/sd/source/ui/inc/fuinsfil.hxx
+++ b/sd/source/ui/inc/fuinsfil.hxx
@@ -22,6 +22,7 @@
 
 #include "fupoor.hxx"
 #include <vector>
+#include <rtl/ustring.hxx>
 
 class SfxMedium;
 
diff --git a/sd/source/ui/inc/fumorph.hxx b/sd/source/ui/inc/fumorph.hxx
index 24890a7bb0a4..3da4fdcdebad 100644
--- a/sd/source/ui/inc/fumorph.hxx
+++ b/sd/source/ui/inc/fumorph.hxx
@@ -22,7 +22,6 @@
 
 #include "fupoor.hxx"
 
-#include <math.h>
 #include <vector>
 
 namespace basegfx {
diff --git a/sd/source/ui/inc/fupage.hxx b/sd/source/ui/inc/fupage.hxx
index b2e19efa4245..a33277d9fa3e 100644
--- a/sd/source/ui/inc/fupage.hxx
+++ b/sd/source/ui/inc/fupage.hxx
@@ -22,6 +22,7 @@
 
 #include <memory>
 #include "fupoor.hxx"
+#include <vcl/weld.hxx>
 
 class SfxItemSet;
 class SdBackgroundObjUndoAction;
diff --git a/sd/source/ui/inc/fupoor.hxx b/sd/source/ui/inc/fupoor.hxx
index 98621639e272..4f003c045709 100644
--- a/sd/source/ui/inc/fupoor.hxx
+++ b/sd/source/ui/inc/fupoor.hxx
@@ -23,8 +23,7 @@
 #include <vcl/timer.hxx>
 #include <tools/link.hxx>
 #include <tools/gen.hxx>
-#include <vcl/event.hxx>
-#include <rtl/ref.hxx>
+#include <vcl/vclptr.hxx>
 
 #include <helper/simplereferencecomponent.hxx>
 
@@ -32,6 +31,10 @@ class SdDrawDocument;
 class SfxRequest;
 class Dialog;
 class SdrObject;
+class CommandEvent;
+class HelpEvent;
+class KeyEvent;
+class MouseEvent;
 
 namespace sd {
 
diff --git a/sd/source/ui/inc/fusel.hxx b/sd/source/ui/inc/fusel.hxx
index a95f6f098446..9491e97eff79 100644
--- a/sd/source/ui/inc/fusel.hxx
+++ b/sd/source/ui/inc/fusel.hxx
@@ -22,7 +22,7 @@
 
 #include "fudraw.hxx"
 
-#include <com/sun/star/media/XPlayer.hpp>
+namespace com { namespace sun { namespace star { namespace media { class XPlayer; } } } }
 
 class SdrHdl;
 class SdrObject;
diff --git a/sd/source/ui/inc/futext.hxx b/sd/source/ui/inc/futext.hxx
index 5b55c28eb491..37ac47b73049 100644
--- a/sd/source/ui/inc/futext.hxx
+++ b/sd/source/ui/inc/futext.hxx
@@ -20,9 +20,8 @@
 #ifndef INCLUDED_SD_SOURCE_UI_INC_FUTEXT_HXX
 #define INCLUDED_SD_SOURCE_UI_INC_FUTEXT_HXX
 
-#include <editeng/editdata.hxx>
 #include "fuconstr.hxx"
-#include <svx/svdotext.hxx>
+#include <tools/weakbase.h>
 
 class SdrTextObj;
 class FontList;
diff --git a/sd/source/ui/inc/futransf.hxx b/sd/source/ui/inc/futransf.hxx
index 4484ade0c961..b044f4b413c1 100644
--- a/sd/source/ui/inc/futransf.hxx
+++ b/sd/source/ui/inc/futransf.hxx
@@ -20,7 +20,6 @@
 #ifndef INCLUDED_SD_SOURCE_UI_INC_FUTRANSF_HXX
 #define INCLUDED_SD_SOURCE_UI_INC_FUTRANSF_HXX
 
-#include <svx/rectenum.hxx>
 #include "fupoor.hxx"
 
 namespace sd {
diff --git a/sd/source/ui/inc/headerfooterdlg.hxx b/sd/source/ui/inc/headerfooterdlg.hxx
index b344c10cef9d..ab699b0b0202 100644
--- a/sd/source/ui/inc/headerfooterdlg.hxx
+++ b/sd/source/ui/inc/headerfooterdlg.hxx
@@ -22,7 +22,6 @@
 #include <vcl/tabdlg.hxx>
 #include <vcl/button.hxx>
 #include <vcl/tabctrl.hxx>
-#include <vcl/tabpage.hxx>
 
 #include <sdpage.hxx>

More information about the Libreoffice-commits mailing list