[Libreoffice-commits] core.git: extensions/source

Tor Lillqvist tml at collabora.com
Mon Jun 25 14:23:43 UTC 2018


 extensions/source/ole/unoobjw.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit 37a2639842a8d86698f2f40e8216c6619c7fa4d8
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon Jun 25 17:19:26 2018 +0300

    Add a FIXME
    
    Change-Id: I3771d6f4703bbd1f012389f5699928464875290f

diff --git a/extensions/source/ole/unoobjw.cxx b/extensions/source/ole/unoobjw.cxx
index 123a4a914412..c0c33b92eff3 100644
--- a/extensions/source/ole/unoobjw.cxx
+++ b/extensions/source/ole/unoobjw.cxx
@@ -1038,6 +1038,10 @@ STDMETHODIMP InterfaceOleWrapper::GetTypeInfo(unsigned int iTInfo, LCID, ITypeIn
     if (iTInfo != 0)
         return E_NOTIMPL;
 
+    // FIXME: This is surely incorrect. Why is being able to handle GetTypeInfo() here coupled to
+    // being a source for outgoing events, i.e. implementing XConnectable? What would break if we
+    // would use XInterfaceWithIID and its getIID instead?
+
     Reference<ooo::vba::XConnectable> xConnectable(m_xOrigin, UNO_QUERY);
     if (!xConnectable.is())
         return E_NOTIMPL;


More information about the Libreoffice-commits mailing list