[Libreoffice-commits] core.git: shell/source

Mike Kaganski mike.kaganski at collabora.com
Wed Mar 7 06:46:03 UTC 2018


 shell/source/win32/simplemail/smplmailclient.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 01c71fba5f525b035f8a723215669d499bc27a3f
Author: Mike Kaganski <mike.kaganski at collabora.com>
Date:   Wed Mar 7 06:45:51 2018 +0100

    Don't return local variable address
    
    Oversight in 2f061dad7f875f704e3744fc5780c1d145b22e9f
    
    Change-Id: I4cd4fcab7f5fa87f49ecc193a3f481fb9ac33932
    Reviewed-on: https://gerrit.libreoffice.org/50857
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/shell/source/win32/simplemail/smplmailclient.cxx b/shell/source/win32/simplemail/smplmailclient.cxx
index 3a659548bbd1..87e324b4eeb5 100644
--- a/shell/source/win32/simplemail/smplmailclient.cxx
+++ b/shell/source/win32/simplemail/smplmailclient.cxx
@@ -170,7 +170,7 @@ namespace {
 // senddoc process lifetime. So we use base temppath for the attachments,
 // and let the senddoc to do the cleanup if it was started successfully.
 // This function works like Desktop::CreateTemporaryDirectory()
-OUString&& InitBaseTempDirURL()
+OUString InitBaseTempDirURL()
 {
     // No need to intercept an exception here, since
     // Desktop::CreateTemporaryDirectory() has ensured that path manager is available
@@ -183,7 +183,7 @@ OUString&& InitBaseTempDirURL()
     if (aRetURL.endsWith("/"))
         aRetURL = aRetURL.copy(0, aRetURL.getLength() - 1);
 
-    return std::move(aRetURL);
+    return aRetURL;
 }
 
 const OUString& GetBaseTempDirURL()


More information about the Libreoffice-commits mailing list