[Libreoffice-commits] core.git: include/i18nutil offapi/com

Eike Rathke erack at redhat.com
Wed Mar 7 20:30:24 UTC 2018


 include/i18nutil/transliteration.hxx                     |    2 ++
 offapi/com/sun/star/i18n/TransliterationModulesExtra.idl |   11 ++++++++++-
 2 files changed, 12 insertions(+), 1 deletion(-)

New commits:
commit 71bf07922b6ff45f9b31fb377d3ac24e172a5c65
Author: Eike Rathke <erack at redhat.com>
Date:   Wed Mar 7 21:29:09 2018 +0100

    Clarify that IGNORE_DIACRITICS_CTL is not only CTL, despite its name
    
    Change-Id: I5954094131debb7cdf0fc44a9db3a3609b356baf

diff --git a/include/i18nutil/transliteration.hxx b/include/i18nutil/transliteration.hxx
index 6294c5eee1e5..f962929b2bdc 100644
--- a/include/i18nutil/transliteration.hxx
+++ b/include/i18nutil/transliteration.hxx
@@ -119,7 +119,9 @@ enum class TransliterationFlags {
     /// transliterate Japanese normal sized character to small sized character
     largeToSmall_ja_JP             = int(css::i18n::TransliterationModules_largeToSmall_ja_JP),
 
+    /// Transliterate decomposing and removing diacritics, not only CTL, despite its name.
     IGNORE_DIACRITICS_CTL          = int(css::i18n::TransliterationModulesExtra::IGNORE_DIACRITICS_CTL),
+    /// Ignore Kashida mark.
     IGNORE_KASHIDA_CTL             = int(css::i18n::TransliterationModulesExtra::IGNORE_KASHIDA_CTL)
 };
 namespace o3tl {
diff --git a/offapi/com/sun/star/i18n/TransliterationModulesExtra.idl b/offapi/com/sun/star/i18n/TransliterationModulesExtra.idl
index be82cf74821a..5a67714ba640 100644
--- a/offapi/com/sun/star/i18n/TransliterationModulesExtra.idl
+++ b/offapi/com/sun/star/i18n/TransliterationModulesExtra.idl
@@ -50,8 +50,17 @@ constants TransliterationModulesExtra
      */
     const short TOGGLE_CASE = 202;
 
-    /// because we cannot extend TransliterationModule we used TranslationModuleExtra and it will act the same way
+    /** Ignore diacritics. Despite the _CTL name suffix this is not only
+        about CTL/Arabic diacritic characters, though these are handled
+        as well, but the transliteration decomposes and removes any
+        diacritic from characters.
+
+        Because we cannot extend the TransliterationModules enum we use
+        TranslationModuleExtra and it will act the same way.
+     */
     const long IGNORE_DIACRITICS_CTL   = 0x40000000;
+
+    /** Ignore Kashida mark. */
     const long IGNORE_KASHIDA_CTL      = 0x00000800;
 
     const long END_OF_MODULE    = 0;


More information about the Libreoffice-commits mailing list