[Libreoffice-commits] core.git: vcl/source

Khaled Hosny khaledhosny at eglug.org
Tue Mar 13 17:04:53 UTC 2018


 vcl/source/gdi/CommonSalLayout.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit ae0a3825f5ad06ff8d6ae3cb388e215d8abe2eb7
Author: Khaled Hosny <khaledhosny at eglug.org>
Date:   Tue Mar 13 16:14:47 2018 +0200

    tdf#116344: Don’t Kashida justify Syriac text
    
    I’ve always suspected this check in VCL is wrong since Writer calculates
    Kashida positions for Arabic only. If we *really* want to Kashida
    justify Syriac, then Writer has to be first taught how to calculate
    Kashida positions for it.
    
    Change-Id: I20c03a3a54bce14c9bebb55426bd22537fe50d6a
    Reviewed-on: https://gerrit.libreoffice.org/51223
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Khaled Hosny <khaledhosny at eglug.org>

diff --git a/vcl/source/gdi/CommonSalLayout.cxx b/vcl/source/gdi/CommonSalLayout.cxx
index de701febe63b..8c509afe3d51 100644
--- a/vcl/source/gdi/CommonSalLayout.cxx
+++ b/vcl/source/gdi/CommonSalLayout.cxx
@@ -723,8 +723,7 @@ bool CommonSalLayout::LayoutText(ImplLayoutArgs& rArgs)
                 if (u_isUWhiteSpace(aChar))
                      nGlyphFlags |= GlyphItem::IS_SPACING;
 
-                if ((aSubRun.maScript == HB_SCRIPT_ARABIC ||
-                     aSubRun.maScript == HB_SCRIPT_SYRIAC) &&
+                if (aSubRun.maScript == HB_SCRIPT_ARABIC &&
                     HB_DIRECTION_IS_BACKWARD(aSubRun.maDirection) &&
                     (nGlyphFlags & GlyphItem::IS_SPACING) == 0)
                 {


More information about the Libreoffice-commits mailing list