[Libreoffice-commits] core.git: filter/source lotuswordpro/source

Jochen Nitschke j.nitschke+logerrit at ok.de
Wed Mar 14 06:23:34 UTC 2018


 filter/source/graphicfilter/idxf/dxftblrd.cxx |   64 ++++++++++++--------------
 lotuswordpro/source/filter/explode.cxx        |    5 --
 lotuswordpro/source/filter/lwppiece.hxx       |    1 
 3 files changed, 32 insertions(+), 38 deletions(-)

New commits:
commit 0fe96112bef31bdfc4f85db78aa4c4f2d1bf1d43
Author: Jochen Nitschke <j.nitschke+logerrit at ok.de>
Date:   Tue Mar 13 20:11:16 2018 +0100

    cppcheck: useInitializationList
    
    Change-Id: I7b3cce8d84176c13801a906af79e353a541135ce
    Reviewed-on: https://gerrit.libreoffice.org/51240
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/filter/source/graphicfilter/idxf/dxftblrd.cxx b/filter/source/graphicfilter/idxf/dxftblrd.cxx
index 54535e9a0430..3975651ac0ea 100644
--- a/filter/source/graphicfilter/idxf/dxftblrd.cxx
+++ b/filter/source/graphicfilter/idxf/dxftblrd.cxx
@@ -166,40 +166,38 @@ void DXFStyle::Read(DXFGroupReader & rDGR)
 //----------------------------------DXFVPort-----------------------------------
 
 DXFVPort::DXFVPort()
+    : pSucc(nullptr)
+    , nFlags(0)
+    , fMinX(0.0)
+    , fMinY(0.0)
+    , fMaxX(0.0)
+    , fMaxY(0.0)
+    , fCenterX(0.0)
+    , fCenterY(0.0)
+    , fSnapBaseX(0.0)
+    , fSnapBaseY(0.0)
+    , fSnapSpacingX(0.0)
+    , fSnapSpacingY(0.0)
+    , fGridX(0.0)
+    , fGridY(0.0)
+    , aDirection(DXFVector(0.0, 0.0, 1.0))
+    , fHeight(0.0)
+    , fAspectRatio(0.0)
+    , fLensLength(0.0)
+    , fFrontClipPlane(0.0)
+    , fBackClipPlane(0.0)
+    , fTwistAngle(0.0)
+    , nStatus(0)
+    , nID(0)
+    , nMode(0)
+    , nCircleZoomPercent(0)
+    , nFastZoom(0)
+    , nUCSICON(0)
+    , nSnap(0)
+    , nGrid(0)
+    , nSnapStyle(0)
+    , nSnapIsopair(0)
 {
-    pSucc=nullptr;
-
-    nFlags=0;
-    fMinX=0;
-    fMinY=0;
-    fMaxX=0;
-    fMaxY=0;
-    fCenterX=0;
-    fCenterY=0;
-    fSnapBaseX=0;
-    fSnapBaseY=0;
-    fSnapSpacingX=0;
-    fSnapSpacingY=0;
-    fGridX=0;
-    fGridY=0;
-    aDirection=DXFVector(0,0,1);
-    aTarget=DXFVector(0,0,0);
-    fHeight=0;
-    fAspectRatio=0;
-    fLensLength=0;
-    fFrontClipPlane=0;
-    fBackClipPlane=0;
-    fTwistAngle=0;
-    nStatus=0;
-    nID=0;
-    nMode=0;
-    nCircleZoomPercent=0;
-    nFastZoom=0;
-    nUCSICON=0;
-    nSnap=0;
-    nGrid=0;
-    nSnapStyle=0;
-    nSnapIsopair=0;
 }
 
 void DXFVPort::Read(DXFGroupReader & rDGR)
diff --git a/lotuswordpro/source/filter/explode.cxx b/lotuswordpro/source/filter/explode.cxx
index 207346c55a26..731c6bc099d9 100644
--- a/lotuswordpro/source/filter/explode.cxx
+++ b/lotuswordpro/source/filter/explode.cxx
@@ -451,11 +451,8 @@ void Decompression::fillArray()
     }
 }
 
-HuffmanTreeNode::HuffmanTreeNode(sal_uInt32 nValue )
+HuffmanTreeNode::HuffmanTreeNode(sal_uInt32 nValue):value(nValue)
 {
-    value = nValue;
-    left = nullptr;
-    right = nullptr;
 }
 HuffmanTreeNode::~HuffmanTreeNode()
 {
diff --git a/lotuswordpro/source/filter/lwppiece.hxx b/lotuswordpro/source/filter/lwppiece.hxx
index 1aaa7453d272..5bfbae7e64bd 100644
--- a/lotuswordpro/source/filter/lwppiece.hxx
+++ b/lotuswordpro/source/filter/lwppiece.hxx
@@ -80,7 +80,6 @@ class LwpVirtualPiece : public LwpDLVList
 public:
     LwpVirtualPiece(LwpObjectHeader const & objHdr, LwpSvStream* pStrm):LwpDLVList(objHdr, pStrm)
     {
-        m_pOverride = nullptr;
     }
 
     virtual void Read() override


More information about the Libreoffice-commits mailing list