[Libreoffice-commits] core.git: desktop/qa officecfg/registry

Samuel Mehrbrodt Samuel.Mehrbrodt at cib.de
Wed Mar 14 19:05:18 UTC 2018


 desktop/qa/desktop_lib/test_desktop_lib.cxx                 |    3 ++-
 officecfg/registry/schema/org/openoffice/Office/Draw.xcs    |    2 +-
 officecfg/registry/schema/org/openoffice/Office/Impress.xcs |    2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

New commits:
commit d799436414ab7e28b6bf9a918fd3779b3fc85008
Author: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
Date:   Wed Mar 14 14:25:44 2018 +0100

    tdf#116342 Allow selecting text boxes anywhere by default
    
    Not only by hitting the (invisble) frame or the text content.
    
    Change-Id: I125f76a102611b628411d8c5acf70e3ed9e5e8fe
    Reviewed-on: https://gerrit.libreoffice.org/51276
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>

diff --git a/desktop/qa/desktop_lib/test_desktop_lib.cxx b/desktop/qa/desktop_lib/test_desktop_lib.cxx
index 4e4c4ee3f6ba..0714b6804ca0 100644
--- a/desktop/qa/desktop_lib/test_desktop_lib.cxx
+++ b/desktop/qa/desktop_lib/test_desktop_lib.cxx
@@ -1280,7 +1280,8 @@ void DesktopLOKTest::testContextMenuImpress()
     pDocument->pClass->initializeForRendering(pDocument, nullptr);
     pDocument->pClass->registerCallback(pDocument, &DesktopLOKTest::callback, this);
 
-    Point aRandomPoint(1150, 1100);
+    // random point where we don't hit an underlying comment or text box
+    Point aRandomPoint(10, 1150);
     pDocument->pClass->postMouseEvent(pDocument,
                                       LOK_MOUSEEVENT_MOUSEBUTTONDOWN,
                                       aRandomPoint.X(), aRandomPoint.Y(),
diff --git a/officecfg/registry/schema/org/openoffice/Office/Draw.xcs b/officecfg/registry/schema/org/openoffice/Office/Draw.xcs
index ac2725eef58f..dab24b019bdc 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Draw.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Draw.xcs
@@ -368,7 +368,7 @@
             <desc>Indicates whether a text frame can only be selected by clicking on the text or by clicking somewhere in the frame.</desc>
             <label>Only text area selectable</label>
           </info>
-          <value>true</value>
+          <value>false</value>
         </prop>
       </group>
       <group oor:name="CrossFading">
diff --git a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
index e421a579a91e..e27df89f8129 100644
--- a/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
+++ b/officecfg/registry/schema/org/openoffice/Office/Impress.xcs
@@ -591,7 +591,7 @@
             <desc>Indicates whether a text frame can only be selected by clicking on the text or by clicking somewhere in the frame.</desc>
             <label>Only text area selectable</label>
           </info>
-          <value>true</value>
+          <value>false</value>
         </prop>
       </group>
       <group oor:name="NewDoc">


More information about the Libreoffice-commits mailing list