[Libreoffice-commits] core.git: sc/source

Caolán McNamara caolanm at redhat.com
Mon Mar 19 20:20:33 UTC 2018


 sc/source/ui/view/drawvie4.cxx |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

New commits:
commit 14244769eb799730a58960c8b2fe3990f44fd0ba
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Mon Mar 19 14:44:51 2018 +0000

    coverity#1430097 Dereference null return value
    
    Change-Id: I1cba6a67c2b94b5906c017960e5636d5e7b87dd2
    Reviewed-on: https://gerrit.libreoffice.org/51565
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/view/drawvie4.cxx b/sc/source/ui/view/drawvie4.cxx
index 4097186358a9..0bf70f79289a 100644
--- a/sc/source/ui/view/drawvie4.cxx
+++ b/sc/source/ui/view/drawvie4.cxx
@@ -550,8 +550,14 @@ void ScDrawView::FitToCellSize()
         return;
     }
 
-    SdrUndoGroup* pUndoGroup = new SdrUndoGroup(*GetModel());
     ScDrawObjData* pObjData = ScDrawLayer::GetObjData(pObj);
+    if (!pObjData)
+    {
+        SAL_WARN("sc.ui", "Missing ScDrawObjData!");
+        return;
+    }
+
+    SdrUndoGroup* pUndoGroup = new SdrUndoGroup(*GetModel());
     tools::Rectangle aGraphicRect = pObj->GetSnapRect();
     tools::Rectangle aCellRect = ScDrawLayer::GetCellRect( *pDoc, pObjData->maStart, true);
 


More information about the Libreoffice-commits mailing list