[Libreoffice-commits] core.git: bin/gbuild-to-ide

Mike Kaganski mike.kaganski at collabora.com
Wed Mar 21 09:04:11 UTC 2018


 bin/gbuild-to-ide |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 234d0368c823eb1a74e973e051ac522e6b86e833
Author: Mike Kaganski <mike.kaganski at collabora.com>
Date:   Wed Mar 21 09:03:59 2018 +0100

    Don't generate filters with empty Includes
    
    Avoids VS warnings:
    
    > smoketest\Library_smoketest.vcxproj.filters : warning  : Unable to
    > read the filters file "Library_smoketest.vcxproj.filters". Please
    > unload the project "Library_smoketest.vcxproj" to be able to edit it.
    > The required attribute "Include" is empty or missing from the element
    > <Filter>.
    
    Change-Id: I0f02e837823a5e7a0355fd0f895f00c63a5df6fc
    Reviewed-on: https://gerrit.libreoffice.org/51684
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/bin/gbuild-to-ide b/bin/gbuild-to-ide
index 48d1a760c781..8507de280d83 100755
--- a/bin/gbuild-to-ide
+++ b/bin/gbuild-to-ide
@@ -945,7 +945,7 @@ class VisualStudioIntegrationGenerator(IdeIntegrationGenerator):
 
     def get_subfilters(self, proj_filter):
         parts = proj_filter.split('\\')
-        subfilters = set([proj_filter])
+        subfilters = set([proj_filter]) if proj_filter else set()
         for i in range(1, len(parts)):
             subfilters.add('\\'.join(parts[:i]))
         return subfilters


More information about the Libreoffice-commits mailing list