[Libreoffice-commits] core.git: writerfilter/source

[Justin Luth]

 writerfilter/source/dmapper/DomainMapper_Impl.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit d47c84a5fd38c1aa28fe6e3144b4efd0226f8f97
Author: Justin Luth <justin_luth at sil.org>
Date:   Wed Mar 21 20:47:11 2018 +0300

    comment: Word does not use tabs in footnote implementation
    
    Tabs are inserted when LO exports to MS formats in an attempt to
    emulate its "magical" spacing which uses the paragraph margin.
    
    By default, the Footnote paragraph style has a paragraph margin of
    0.60cm. A hanging indent places the footnote character before the
    margin, and thus a tab advances to the margin. So the emulation
    works well.
    
    The previous comment was misleading because it suggests that this
    was a Microsoft convention, but actually this is an OOo innovation.
    
    Change-Id: Ie8708998457bcb3363bbc760086cf2b41d3eb104
    Reviewed-on: https://gerrit.libreoffice.org/51753
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Justin Luth <justin_luth at sil.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/writerfilter/source/dmapper/DomainMapper_Impl.cxx b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
index 3526f8b38a69..7755480dffed 100644
--- a/writerfilter/source/dmapper/DomainMapper_Impl.cxx
+++ b/writerfilter/source/dmapper/DomainMapper_Impl.cxx
@@ -1827,9 +1827,9 @@ void DomainMapper_Impl::PushFootOrEndnote( bool bIsFootnote )
         // Redlines for the footnote anchor
         CheckRedline( xFootnote->getAnchor( ) );
 
-        // Word has a leading tab on footnotes, but we may implement space
-        // between the footnote number and text using a paragraph margin, not a
-        // tab (Writer default). So ignore that in case there is a margin set.
+        // LO inserts a tab when exporting to MS formats in order to emulate its automatic space
+        // between the footnote number and text using the paragraph margin.
+        // So ignore that tab when there is a margin set.
         uno::Reference<style::XStyleFamiliesSupplier> xStylesSupplier( GetTextDocument(), uno::UNO_QUERY);
         uno::Reference<container::XNameAccess> xStyleFamilies = xStylesSupplier->getStyleFamilies();
         uno::Reference<container::XNameContainer> xStyles;