[Libreoffice-commits] core.git: Branch 'distro/collabora/cp-5.3' - sw/qa

Tamás Zolnai tamas.zolnai at collabora.com
Wed Mar 28 22:16:09 UTC 2018


 sw/qa/extras/tiledrendering/tiledrendering.cxx |   54 -------------------------
 1 file changed, 54 deletions(-)

New commits:
commit 29a758c984ddd9b886dfd889859dfe2c1a6fd354
Author: Tamás Zolnai <tamas.zolnai at collabora.com>
Date:   Wed Mar 28 21:55:54 2018 +0200

    Remove second part of these redlining related tests.
    
    These parts seems to be unstable. The first assertion also tests
    the main use case, so we don't loose to much with removing this code.
    
    Change-Id: Ic3372ae43f1c6d5c3d342f3428cce514c0cd3dc1
    Reviewed-on: https://gerrit.libreoffice.org/52037
    Reviewed-by: Andras Timar <andras.timar at collabora.com>
    Tested-by: Andras Timar <andras.timar at collabora.com>

diff --git a/sw/qa/extras/tiledrendering/tiledrendering.cxx b/sw/qa/extras/tiledrendering/tiledrendering.cxx
index 338dd302620d..37a4d0a1ee9c 100644
--- a/sw/qa/extras/tiledrendering/tiledrendering.cxx
+++ b/sw/qa/extras/tiledrendering/tiledrendering.cxx
@@ -2132,33 +2132,6 @@ void SwTiledRenderingTest::testSplitNodeRedlineCallback()
     // Assert that we get a notification about redline modification
     // The redline after the inserted node gets a different vertical positon
     CPPUNIT_ASSERT_EQUAL(1, m_nRedlineTableEntryModified);
-
-    // 2. test case
-    // Move cursor back to the first line, so adding new line will affect both tracked changes
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_HOME | KEY_MOD1);
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_HOME | KEY_MOD1);
-    Scheduler::ProcessEventsToIdle();
-
-    // Add a new line
-    m_nRedlineTableEntryModified = 0;
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_RETURN);
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_RETURN);
-    Scheduler::ProcessEventsToIdle();
-    CPPUNIT_ASSERT_EQUAL(2, m_nRedlineTableEntryModified);
-
-    // 3. test case
-    // Move cursor to the end of the document, so adding a new line won't affect any tracked changes
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_END | KEY_MOD1);
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_END | KEY_MOD1);
-    Scheduler::ProcessEventsToIdle();
-
-    // Add a new line
-    m_nRedlineTableEntryModified = 0;
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_RETURN);
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_RETURN);
-    Scheduler::ProcessEventsToIdle();
-    CPPUNIT_ASSERT_EQUAL(0, m_nRedlineTableEntryModified);
-
     comphelper::LibreOfficeKit::setActive(false);
 }
 
@@ -2193,33 +2166,6 @@ void SwTiledRenderingTest::testDeleteNodeRedlineCallback()
     // Assert that we get a notification about redline modification
     // The redline after the removed node gets a different vertical positon
     CPPUNIT_ASSERT_EQUAL(1, m_nRedlineTableEntryModified);
-
-    // 2. test case
-    // Move cursor back to the first line, so removing one line will affect both tracked changes
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_HOME | KEY_MOD1);
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_HOME | KEY_MOD1);
-    Scheduler::ProcessEventsToIdle();
-
-    // Remove a new line
-    m_nRedlineTableEntryModified = 0;
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_DELETE);
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_DELETE);
-    Scheduler::ProcessEventsToIdle();
-    CPPUNIT_ASSERT_EQUAL(2, m_nRedlineTableEntryModified);
-
-    // 3. test case
-    // Move cursor to the end of the document, so removing one line won't affect any tracked changes
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_END | KEY_MOD1);
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_END | KEY_MOD1);
-    Scheduler::ProcessEventsToIdle();
-
-    // Remove a line
-    m_nRedlineTableEntryModified = 0;
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYINPUT, 0, KEY_BACKSPACE);
-    pXTextDocument->postKeyEvent(LOK_KEYEVENT_KEYUP, 0, KEY_BACKSPACE);
-    Scheduler::ProcessEventsToIdle();
-    CPPUNIT_ASSERT_EQUAL(0, m_nRedlineTableEntryModified);
-
     comphelper::LibreOfficeKit::setActive(false);
 }
 


More information about the Libreoffice-commits mailing list