[Libreoffice-commits] core.git: svx/source

[Armin Le Grand (CIB)]

 svx/source/svdraw/svdview.cxx |    7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

New commits:
commit 7a6b66942260837e2a627b1df2a4fee9af1e3227
Author: Armin Le Grand <Armin.Le.Grand at cib.de (CIB)>
Date:   Wed Mar 28 16:55:19 2018 +0200

    Allow URL-Check for non-selected TableText
    
    The part to detect a hit on a TableObjectText
    in Draw/Impress for a non-selected Table was
    setting the HitType to SdrHitKind::TextEditObj.
    This prevents the latter happeing check for URL
    (see below). Not directly setting to TextEditObj
    is okay, this is determined and set later. I
    checked various possible changes to keep the
    behaviour as for 'normal' SdrObjects, so please
    be careful when doing changes in the HitTest code
    
    Change-Id: I326a73b88fc56fd902b5052cc3a2ddecf3c3ba61
    Reviewed-on: https://gerrit.libreoffice.org/52016
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Armin Le Grand <Armin.Le.Grand at cib.de>

diff --git a/svx/source/svdraw/svdview.cxx b/svx/source/svdraw/svdview.cxx
index b5dbcd4959f8..1d44319efe5b 100644
--- a/svx/source/svdraw/svdview.cxx
+++ b/svx/source/svdraw/svdview.cxx
@@ -380,7 +380,12 @@ SdrHitKind SdrView::PickAnything(const Point& rLogicPos, SdrViewEvent& rVEvt) co
                     eHit = SdrHitKind::Cell;
                     break;
                 case sdr::table::TableHitKind::CellTextArea:
-                    eHit = SdrHitKind::TextEditObj;
+                    // Keep state on UnmarkedObject to allow the below
+                    // 'check for URL field' to be executed, else popups
+                    // for e.g. URL links when hoovering and clicking
+                    // them will not work. Tried several other changes,
+                    // but this oje safely keeps existing behaviour as-is.
+                    eHit = SdrHitKind::UnmarkedObject;
                     break;
                 default:
                     break;