[Libreoffice-commits] core.git: vcl/qa

Mike Kaganski mike.kaganski at collabora.com
Thu Mar 29 13:54:20 UTC 2018


 vcl/qa/cppunit/pdfexport/pdfexport.cxx |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

New commits:
commit 36c4fe664c90cebe3456bcb2cc3c463f94bf4dd0
Author: Mike Kaganski <mike.kaganski at collabora.com>
Date:   Thu Mar 29 12:09:03 2018 +0100

    Don't run testTdf107868 on Windows, since it's using GDI
    
    The intent of the test is to trigger PDF export. On Windows, GDI printing
    is used, so no use to run it (and it would provide a sane PDF with 2 white
    paths).
    
    Change-Id: I808807ce0d339cccbb3d097f486d2562e7b2819f
    Reviewed-on: https://gerrit.libreoffice.org/52072
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>
    Tested-by: Jenkins <ci at libreoffice.org>

diff --git a/vcl/qa/cppunit/pdfexport/pdfexport.cxx b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
index d0fa68cfa525..b039d25d8d5a 100644
--- a/vcl/qa/cppunit/pdfexport/pdfexport.cxx
+++ b/vcl/qa/cppunit/pdfexport/pdfexport.cxx
@@ -288,9 +288,10 @@ void PdfExportTest::testTdf105461()
 
 void PdfExportTest::testTdf107868()
 {
+    // No need to run it on Windows, since it would use GDI printing, and not trigger PDF export
+    // which is the intent of the test.
     // FIXME: Why does this fail on macOS?
-    // FIXME: Why does this fail when building 64bit?
-#if !defined MACOSX && !defined _WIN64
+#if !defined MACOSX && !defined _WIN32
     // Import the bugdoc and print to PDF.
     OUString aURL = m_directories.getURLFromSrc(DATA_DIRECTORY) + "tdf107868.odt";
     mxComponent = loadFromDesktop(aURL);


More information about the Libreoffice-commits mailing list