[Libreoffice-commits] core.git: svx/source

[Noel Grandin]

 svx/source/accessibility/AccessibleTextHelper.cxx |   11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

New commits:
commit 03a4b6eb58b29c0ab4bb85f756923c46618d02ff
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Wed May 2 10:00:39 2018 +0200

    tdf#117205 impress crash when moving an item in a list
    
    regression from
       commit 891e41fac81fbd8d5cdb277b26639abfd25a7143 (patch)
       dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren
    
    Change-Id: I0db104fcde91597dc71b6cae6c547a0cedac4af2
    Reviewed-on: https://gerrit.libreoffice.org/53721
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svx/source/accessibility/AccessibleTextHelper.cxx b/svx/source/accessibility/AccessibleTextHelper.cxx
index 9f1061bf0cac..2707d768c273 100644
--- a/svx/source/accessibility/AccessibleTextHelper.cxx
+++ b/svx/source/accessibility/AccessibleTextHelper.cxx
@@ -759,12 +759,15 @@ namespace accessibility
             SvxTextForwarder& rCacheTF = GetTextForwarder();
             sal_Int32 nParas=rCacheTF.GetParagraphCount();
 
-            mnFirstVisibleChild = nParas ? 0 : -1;
+            mnFirstVisibleChild = -1;
             mnLastVisibleChild = -2;
 
-            if (mxFrontEnd.is() && bBroadcastEvents)
+            for( sal_Int32 nCurrPara=0; nCurrPara<nParas; ++nCurrPara )
             {
-                for( sal_Int32 nCurrPara=0; nCurrPara<nParas; ++nCurrPara )
+                if (nCurrPara == 0)
+                    mnFirstVisibleChild = nCurrPara;
+                mnLastVisibleChild = nCurrPara;
+                if (mxFrontEnd.is() && bBroadcastEvents)
                 {
                     // child not yet created?
                     ::accessibility::AccessibleParaManager::WeakChild aChild( maParaManager.GetChild(nCurrPara) );
@@ -777,8 +780,6 @@ namespace accessibility
                     }
                 }
             }
-
-            mnLastVisibleChild = nParas - 1;
         }
         catch( const uno::Exception& )
         {