[Libreoffice-commits] core.git: solenv/gbuild solenv/sanitizers
Samuel Thibault
sthibault at hypra.fr
Fri May 4 01:15:06 UTC 2018
solenv/gbuild/UIConfig.mk | 2 +-
solenv/sanitizers/ui/cui.suppr | 13 +++++++++----
solenv/sanitizers/ui/modules/scalc.suppr | 5 +++++
solenv/sanitizers/ui/modules/schart.suppr | 3 ++-
solenv/sanitizers/ui/modules/swriter.suppr | 14 ++++++++++++++
solenv/sanitizers/ui/svx.suppr | 7 +++++++
6 files changed, 38 insertions(+), 6 deletions(-)
New commits:
commit 936eaedddbc6d21737745be3c3131607440e366c
Author: Samuel Thibault <sthibault at hypra.fr>
Date: Mon Apr 23 10:54:20 2018 +0200
gla11y: Enable duplicate labelling warnings
Change-Id: Id9022aad4538caa08c3de9a76ff97282cfefb828
Reviewed-on: https://gerrit.libreoffice.org/53314
Tested-by: Jenkins <ci at libreoffice.org>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>
diff --git a/solenv/gbuild/UIConfig.mk b/solenv/gbuild/UIConfig.mk
index 1d9ede0986d1..e208d99a7309 100644
--- a/solenv/gbuild/UIConfig.mk
+++ b/solenv/gbuild/UIConfig.mk
@@ -167,7 +167,7 @@ gb_UIConfig_gla11y_PARAMETERS += --enable-type missing-labelled-by
# These are often buttons with only an image
gb_UIConfig_gla11y_PARAMETERS += --enable-type button-no-label
# These are often doubtful
-#gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type labelled-by-and-mnemonic
+gb_UIConfig_gla11y_PARAMETERS += --enable-type duplicate-mnemonic --enable-type labelled-by-and-mnemonic
# For now, disable warning about widgets without a label by default, to enable warnings for classes progressively
# To be uncommented progressively
diff --git a/solenv/sanitizers/ui/cui.suppr b/solenv/sanitizers/ui/cui.suppr
index 3cf4f506104c..faf5d9357fdd 100644
--- a/solenv/sanitizers/ui/cui.suppr
+++ b/solenv/sanitizers/ui/cui.suppr
@@ -1,3 +1,5 @@
+cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='C_custom:0%'] duplicate-mnemonic
+cui/uiconfig/ui/colorpage.ui://GtkSpinButton[@id='K_custom:0%'] duplicate-mnemonic
cui/uiconfig/ui/comment.ui://GtkButton[@id='previous'] button-no-label
cui/uiconfig/ui/comment.ui://GtkButton[@id='next'] button-no-label
cui/uiconfig/ui/gradientpage.ui://GtkScale[@id='incrementslider'] no-labelled-by
@@ -11,6 +13,8 @@ cui/uiconfig/ui/hatchpage.ui://GtkLabel[@id='linecolorft'] orphan-label
cui/uiconfig/ui/hyphenate.ui://GtkLabel[@id='label1'] orphan-label
cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='left'] button-no-label
cui/uiconfig/ui/hyphenate.ui://GtkButton[@id='right'] button-no-label
+cui/uiconfig/ui/menuassignpage.ui://GtkTextView[@id='desc:border'] labelled-by-and-mnemonic
+cui/uiconfig/ui/newlibdialog.ui://GtkEntry[@id='entry'] duplicate-mnemonic
cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='browsetitle'] orphan-label
cui/uiconfig/ui/optemailpage.ui://GtkLabel[@id='suppress'] orphan-label
cui/uiconfig/ui/optemailpage.ui://GtkCheckButton[@id='suppressHidden'] button-no-label
@@ -20,6 +24,9 @@ cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='font'] orphan-label
cui/uiconfig/ui/optfontspage.ui://GtkLabel[@id='replacewith'] orphan-label
cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='apply'] button-no-label
cui/uiconfig/ui/optfontspage.ui://GtkButton[@id='delete'] button-no-label
+cui/uiconfig/ui/optviewpage.ui://GtkComboBoxText[@id='iconsize'] duplicate-mnemonic
+cui/uiconfig/ui/pageformatpage.ui://GtkSpinButton[@id='spinMargLeft:0.00cm'] duplicate-mnemonic
+cui/uiconfig/ui/pageformatpage.ui://GtkSpinButton[@id='spinMargRight:0.00cm'] duplicate-mnemonic
cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default1'] button-no-label
cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default2'] button-no-label
cui/uiconfig/ui/personalization_tab.ui://GtkButton[@id='default3'] button-no-label
@@ -42,8 +49,6 @@ cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result7'] button-no-la
cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result8'] button-no-label
cui/uiconfig/ui/select_persona_dialog.ui://GtkButton[@id='result9'] button-no-label
cui/uiconfig/ui/select_persona_dialog.ui://GtkLabel[@id='progress_label'] orphan-label
-cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinPageNumber'] missing-label-for
-cui/uiconfig/ui/textflowpage.ui://GtkComboBox[@id='comboPageStyle'] missing-label-for
-cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinOrphan'] missing-label-for
-cui/uiconfig/ui/textflowpage.ui://GtkSpinButton[@id='spinWidow'] missing-label-for
+cui/uiconfig/ui/signsignatureline.ui://GtkTextView[@id='edit_comment'] duplicate-mnemonic
cui/uiconfig/ui/thesaurus.ui://GtkButton[@id='left'] button-no-label
+cui/uiconfig/ui/wordcompletionpage.ui://GtkSpinButton[@id='maxentries'] duplicate-mnemonic
diff --git a/solenv/sanitizers/ui/modules/scalc.suppr b/solenv/sanitizers/ui/modules/scalc.suppr
index 28d6cc96060e..6e20952ada84 100644
--- a/solenv/sanitizers/ui/modules/scalc.suppr
+++ b/solenv/sanitizers/ui/modules/scalc.suppr
@@ -1,3 +1,4 @@
+sc/uiconfig/scalc/ui/datafieldoptionsdialog.ui://GtkComboBoxText[@id='layout'] duplicate-mnemonic
sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='connect1'] missing-label-for
sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field1'] missing-label-for
sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='field2'] missing-label-for
@@ -8,6 +9,7 @@ sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='cond3'] missing
sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val1'] missing-label-for
sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val2'] missing-label-for
sc/uiconfig/scalc/ui/pivotfilterdialog.ui://GtkComboBoxText[@id='val3'] missing-label-for
+sc/uiconfig/scalc/ui/regressiondialog.ui://foruilo-RefEdit[@id='variable2-range-edit'] duplicate-mnemonic
sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='connect1'] missing-label-for
sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='connect2'] missing-label-for
sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='field1'] missing-label-for
@@ -20,4 +22,7 @@ sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val1'] missi
sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val2'] missing-label-for
sc/uiconfig/scalc/ui/standardfilterdialog.ui://GtkComboBoxText[@id='val3'] missing-label-for
sc/uiconfig/scalc/ui/sidebaralignment.ui://GtkSpinButton[@id='leftindent:0pt'] missing-label-for
+sc/uiconfig/scalc/ui/sidebaralignment.ui://GtkSpinButton[@id='leftindent:0pt'] labelled-by-and-mnemonic
sc/uiconfig/scalc/ui/sidebaralignment.ui://VclComboBoxNumeric[@id='orientationdegrees:0degrees'] missing-label-for
+sc/uiconfig/scalc/ui/ttestdialog.ui://foruilo-RefEdit[@id='variable2-range-edit'] duplicate-mnemonic
+sc/uiconfig/scalc/ui/ztestdialog.ui://foruilo-RefEdit[@id='variable2-range-edit'] duplicate-mnemonic
diff --git a/solenv/sanitizers/ui/modules/schart.suppr b/solenv/sanitizers/ui/modules/schart.suppr
index 59bbd1918e4f..49e76c603014 100644
--- a/solenv/sanitizers/ui/modules/schart.suppr
+++ b/solenv/sanitizers/ui/modules/schart.suppr
@@ -1,7 +1,8 @@
chart2/uiconfig/ui/dlg_InsertErrorBars.ui://GtkRadioButton[@id='RB_FUNCTION'] button-no-label
+chart2/uiconfig/ui/sidebarelements.ui://GtkCheckButton[@id='checkbutton_legend'] button-no-label
+chart2/uiconfig/ui/sidebarelements.ui://GtkLabel[@id='placement_label'] orphan-label
chart2/uiconfig/ui/tp_DataSource.ui://GtkLabel[@id='FT_CAPTION_FOR_WIZARD'] orphan-label
chart2/uiconfig/ui/tp_DataSource.ui://GtkButton[@id='IMB_RANGE_MAIN'] button-no-label
chart2/uiconfig/ui/tp_DataSource.ui://GtkLabel[@id='FT_DATALABELS'] orphan-label
chart2/uiconfig/ui/tp_DataSource.ui://GtkButton[@id='IMB_RANGE_CAT'] button-no-label
chart2/uiconfig/ui/tp_ErrorBars.ui://GtkRadioButton[@id='RB_FUNCTION'] button-no-label
-chart2/uiconfig/ui/sidebarelements.ui://GtkCheckButton[@id='checkbutton_legend'] button-no-label
diff --git a/solenv/sanitizers/ui/modules/swriter.suppr b/solenv/sanitizers/ui/modules/swriter.suppr
index 997026c1bcb1..45cc24c1017f 100644
--- a/solenv/sanitizers/ui/modules/swriter.suppr
+++ b/solenv/sanitizers/ui/modules/swriter.suppr
@@ -1,9 +1,18 @@
sw/uiconfig/swriter/ui/addressblockdialog.ui://GtkButton[@id='toaddr'] button-no-label
+sw/uiconfig/swriter/ui/businessdatapage.ui://GtkEntry[@id='position'] duplicate-mnemonic
+sw/uiconfig/swriter/ui/columnpage.ui://GtkSpinButton[@id='width3mf:0.00cm'] labelled-by-and-mnemonic
+sw/uiconfig/swriter/ui/columnpage.ui://GtkSpinButton[@id='width2mf:0.00cm'] labelled-by-and-mnemonic
+sw/uiconfig/swriter/ui/columnpage.ui://GtkSpinButton[@id='width1mf:0.00cm'] labelled-by-and-mnemonic
+sw/uiconfig/swriter/ui/columnpage.ui://GtkSpinButton[@id='linewidthmf:0.00pt'] duplicate-mnemonic
sw/uiconfig/swriter/ui/customizeaddrlistdialog.ui://GtkButton[@id='down'] button-no-label
sw/uiconfig/swriter/ui/customizeaddrlistdialog.ui://GtkButton[@id='up'] button-no-label
sw/uiconfig/swriter/ui/dropdownfielddialog.ui://GtkButton[@id='prev'] button-no-label
sw/uiconfig/swriter/ui/dropdownfielddialog.ui://GtkButton[@id='next'] button-no-label
+sw/uiconfig/swriter/ui/editsectiondialog.ui://GtkEntry[@id='filename'] duplicate-mnemonic
+sw/uiconfig/swriter/ui/flddocumentpage.ui://GtkSpinButton[@id='offset'] duplicate-mnemonic
+sw/uiconfig/swriter/ui/frmtypepage.ui://GtkSpinButton[@id='width:0.00cm'] duplicate-mnemonic
sw/uiconfig/swriter/ui/frmtypepage.ui://GtkCheckButton[@id='relwidth'] missing-labelled-by
+sw/uiconfig/swriter/ui/frmtypepage.ui://GtkSpinButton[@id='height:0.00cm'] duplicate-mnemonic
sw/uiconfig/swriter/ui/frmtypepage.ui://GtkCheckButton[@id='relheight'] missing-labelled-by
sw/uiconfig/swriter/ui/headerfootermenu.ui://GtkMenuItem[@id='edit'] button-no-label
sw/uiconfig/swriter/ui/headerfootermenu.ui://GtkMenuItem[@id='delete'] button-no-label
@@ -20,18 +29,23 @@ sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkButton[@id='toedit'] button
sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkButton[@id='oneleft'] button-no-label
sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkButton[@id='allleft'] button-no-label
sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkComboBoxText[@id='parastyle'] missing-label-for
+sw/uiconfig/swriter/ui/insertdbcolumnsdialog.ui://GtkComboBoxText[@id='parastyle'] labelled-by-and-mnemonic
sw/uiconfig/swriter/ui/insertfootnote.ui://GtkButton[@id='prev'] button-no-label
sw/uiconfig/swriter/ui/insertfootnote.ui://GtkButton[@id='next'] button-no-label
sw/uiconfig/swriter/ui/insertscript.ui://GtkButton[@id='previous'] button-no-label
sw/uiconfig/swriter/ui/insertscript.ui://GtkButton[@id='next'] button-no-label
sw/uiconfig/swriter/ui/insertscript.ui://GtkLabel[@id='label1'] orphan-label
+sw/uiconfig/swriter/ui/labelformatpage.ui://GtkSpinButton[@id='top'] duplicate-mnemonic
sw/uiconfig/swriter/ui/numparapage.ui://GtkCheckButton[@id='checkCB_NUMBER_NEW_START'] missing-labelled-by
+sw/uiconfig/swriter/ui/privateuserpage.ui://GtkEntry[@id='title'] duplicate-mnemonic
sw/uiconfig/swriter/ui/readonlymenu.ui://GtkMenuItem[@id='backgroundtogallery'] button-no-label
sw/uiconfig/swriter/ui/readonlymenu.ui://GtkMenuItem[@id='backaslink'] button-no-label
sw/uiconfig/swriter/ui/readonlymenu.ui://GtkMenuItem[@id='backascopy'] button-no-label
+sw/uiconfig/swriter/ui/sectionpage.ui://GtkEntry[@id='filename'] duplicate-mnemonic
sw/uiconfig/swriter/ui/spellmenu.ui://GtkMenuItem[@id='spelldialog'] button-no-label
sw/uiconfig/swriter/ui/spellmenu.ui://GtkMenuItem[@id='correctdialog'] button-no-label
sw/uiconfig/swriter/ui/tocindexpage.ui://GtkButton[@id='styles'] missing-label-for
+sw/uiconfig/swriter/ui/tocindexpage.ui://svxcorelo-SvxLanguageBox[@id='lang'] duplicate-mnemonic
sw/uiconfig/swriter/ui/tocstylespage.ui://GtkButton[@id='assign'] button-no-label
sw/uiconfig/swriter/ui/tablecolumnpage.ui://GtkButton[@id='back'] button-no-label
sw/uiconfig/swriter/ui/tablecolumnpage.ui://GtkButton[@id='next'] button-no-label
diff --git a/solenv/sanitizers/ui/svx.suppr b/solenv/sanitizers/ui/svx.suppr
index dd932ed8faa9..18c2a976745b 100644
--- a/solenv/sanitizers/ui/svx.suppr
+++ b/solenv/sanitizers/ui/svx.suppr
@@ -1,7 +1,10 @@
+svx/uiconfig/ui/addinstancedialog.ui://GtkEntry[@id='name'] duplicate-mnemonic
svx/uiconfig/ui/colorwindow.ui://GtkButton[@id='auto_color_button'] button-no-label
svx/uiconfig/ui/colorwindow.ui://GtkLabel[@id='label1'] orphan-label
svx/uiconfig/ui/compressgraphicdialog.ui://GtkScale[@id='scale-quality'] no-labelled-by
svx/uiconfig/ui/compressgraphicdialog.ui://GtkScale[@id='scale-compression'] no-labelled-by
+svx/uiconfig/ui/docking3deffects.ui://GtkSpinButton[@id='hori'] duplicate-mnemonic
+svx/uiconfig/ui/docking3deffects.ui://GtkSpinButton[@id='veri'] duplicate-mnemonic
svx/uiconfig/ui/mediaplayback.ui://GtkLabel[@id='label1'] orphan-label
svx/uiconfig/ui/mediaplayback.ui://GtkLabel[@id='label2'] orphan-label
svx/uiconfig/ui/mediaplayback.ui://GtkLabel[@id='label3'] orphan-label
@@ -20,9 +23,13 @@ svx/uiconfig/ui/sidebarshadow.ui://GtkLabel[@id='transparency_label'] orphan-lab
svx/uiconfig/ui/sidebarshadow.ui://GtkScale[@id='transparency_slider'] no-labelled-by
svx/uiconfig/ui/sidebarshadow.ui://GtkLabel[@id='color'] orphan-label
svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='setbrightness:%'] missing-label-for
+svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='setbrightness:%'] labelled-by-and-mnemonic
svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='setcontrast:%'] missing-label-for
+svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='setcontrast:%'] labelled-by-and-mnemonic
svx/uiconfig/ui/sidebargraphic.ui://GtkComboBoxText[@id='setcolormode'] missing-label-for
+svx/uiconfig/ui/sidebargraphic.ui://GtkComboBoxText[@id='setcolormode'] labelled-by-and-mnemonic
svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='settransparency:%'] missing-label-for
+svx/uiconfig/ui/sidebargraphic.ui://GtkSpinButton[@id='settransparency:%'] labelled-by-and-mnemonic
svx/uiconfig/ui/sidebarline.ui://GtkSpinButton[@id='linetransparency:0%'] missing-label-for
svx/uiconfig/ui/sidebarpossize.ui://GtkSpinButton[@id='horizontalpos:0in'] missing-label-for
svx/uiconfig/ui/sidebarpossize.ui://GtkSpinButton[@id='verticalpos:0in'] missing-label-for
More information about the Libreoffice-commits
mailing list