[Libreoffice-commits] core.git: 2 commits - svx/source vcl/source

Caolán McNamara caolanm at redhat.com
Sun May 6 20:03:57 UTC 2018


 svx/source/accessibility/svxrectctaccessiblecontext.cxx |    8 ++++----
 vcl/source/image/ImplImageTree.cxx                      |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

New commits:
commit ec3eac9cfeafca69c61ef7b50687a897087f1835
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun May 6 14:59:25 2018 +0100

    coverity#1435442 silence Unchecked return value
    
    Change-Id: Ifb8a72f250e20f2932c0c03a4d41c999b85db0a3
    Reviewed-on: https://gerrit.libreoffice.org/53916
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/vcl/source/image/ImplImageTree.cxx b/vcl/source/image/ImplImageTree.cxx
index 274c4e60f8d2..d48cd3044b07 100644
--- a/vcl/source/image/ImplImageTree.cxx
+++ b/vcl/source/image/ImplImageTree.cxx
@@ -604,7 +604,7 @@ bool ImplImageTree::checkPathAccess()
 
 css::uno::Reference<css::container::XNameAccess> const & ImplImageTree::getNameAccess()
 {
-    checkPathAccess();
+    (void)checkPathAccess();
     return getCurrentIconSet().maNameAccess;
 }
 
commit f0886f4e7654078bd053c8d400b682171aff850b
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Sun May 6 14:55:44 2018 +0100

    coverity#1435443 Arguments in wrong order
    
    and
    
    coverity#1435439 Arguments in wrong order
    coverity#1435437 Arguments in wrong order
    
    Change-Id: I8dc4166640613ce25c9d01624d607568e42edac9
    Reviewed-on: https://gerrit.libreoffice.org/53915
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/svx/source/accessibility/svxrectctaccessiblecontext.cxx b/svx/source/accessibility/svxrectctaccessiblecontext.cxx
index e6c0959d20d3..62ae619a6c00 100644
--- a/svx/source/accessibility/svxrectctaccessiblecontext.cxx
+++ b/svx/source/accessibility/svxrectctaccessiblecontext.cxx
@@ -851,7 +851,7 @@ void RectCtlAccessibleContext::FireChildFocus( RectPoint eButton )
             Any                             aOld;
             Any                             aNew;
             aNew <<= AccessibleStateType::FOCUSED;
-            NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aNew, aOld);
+            NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aOld, aNew);
         }
     }
     else
@@ -1545,11 +1545,11 @@ void RectCtlChildAccessibleContext::setStateChecked( bool bChecked )
 
         //Send the STATE_CHANGED(Focused) event to accessible
         rMod <<= AccessibleStateType::FOCUSED;
-        NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aNew, aOld);
+        NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aOld, aNew);
 
         rMod <<= AccessibleStateType::CHECKED;
 
-        NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aNew, aOld);
+        NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aOld, aNew);
     }
 }
 
@@ -1558,7 +1558,7 @@ void RectCtlChildAccessibleContext::FireFocusEvent()
     Any                             aOld;
     Any                             aNew;
     aNew <<= AccessibleStateType::FOCUSED;
-    NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aNew, aOld);
+    NotifyAccessibleEvent(AccessibleEventId::STATE_CHANGED, aOld, aNew);
 }
 
 IMPLEMENT_FORWARD_XINTERFACE2( RectCtlChildAccessibleContext, OAccessibleComponentHelper, OAccessibleHelper_Base_3 )


More information about the Libreoffice-commits mailing list