[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml

Gabor Kelemen kelemeng at ubuntu.com
Mon May 7 13:19:27 UTC 2018


 sc/IwyuFilter_sc.yaml    |   40 ++++++++++++++++++++++++++++++++++++++++
 sc/inc/afmtuno.hxx       |    6 ------
 sc/inc/arealink.hxx      |    2 --
 sc/inc/attrib.hxx        |    1 -
 sc/inc/autonamecache.hxx |    1 -
 5 files changed, 40 insertions(+), 10 deletions(-)

New commits:
commit c0893305bf673bd706a8fec014eedfd104dbe88f
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Sat May 5 23:09:12 2018 +0200

    tdf#42949 Fix IWYU warnings in sc/inc/[aA]*
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here.
    
    Change-Id: I1b9193e0d7b320d2b64636eca1bc71041e338d45
    Reviewed-on: https://gerrit.libreoffice.org/53900
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index ff22e0e3a659..e81a97ec325c 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -1,2 +1,42 @@
 ---
 assumeFilename: sc/source/core/data/document.cxx
+blacklist:
+    sc/inc/AccessibleGlobal.hxx:
+    # base class has to be a complete type
+    - com/sun/star/accessibility/XAccessibleStateSet.hpp
+    sc/inc/AccessibleFilterMenu.hxx:
+    # base class has to be a complete type
+    - com/sun/star/accessibility/XAccessibleSelection.hpp
+    sc/inc/AccessibleFilterMenuItem.hxx:
+    # base class has to be a complete type
+    - com/sun/star/accessibility/XAccessibleAction.hpp
+    sc/inc/address.hxx:
+    # base class has to be a complete type
+    - com/sun/star/uno/Sequence.hxx
+    sc/inc/addruno.hxx:
+    # base class has to be a complete type
+    - com/sun/star/beans/XPropertySet.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    sc/inc/afmtuno.hxx:
+    # base class has to be a complete type
+    - com/sun/star/beans/XPropertySet.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/lang/XUnoTunnel.hpp
+    - com/sun/star/container/XIndexReplace.hpp
+    - com/sun/star/container/XNameContainer.hpp
+    - com/sun/star/container/XNameReplace.hpp
+    - com/sun/star/container/XNamed.hpp
+    - com/sun/star/container/XSet.hpp
+    sc/inc/appluno.hxx:
+    # base class has to be a complete type
+    - com/sun/star/beans/XPropertySet.hpp
+    - com/sun/star/container/XEnumerationAccess.hpp
+    - com/sun/star/container/XNameAccess.hpp
+    - com/sun/star/lang/XMultiServiceFactory.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/sheet/XFunctionDescriptions.hpp
+    - com/sun/star/sheet/XGlobalSheetSettings.hpp
+    - com/sun/star/sheet/XRecentFunctions.hpp
+    sc/inc/autoform.hxx:
+    # contains macro definitions
+    - scitems.hxx
diff --git a/sc/inc/afmtuno.hxx b/sc/inc/afmtuno.hxx
index 27436be98963..09172e84fa63 100644
--- a/sc/inc/afmtuno.hxx
+++ b/sc/inc/afmtuno.hxx
@@ -20,21 +20,15 @@
 #ifndef INCLUDED_SC_INC_AFMTUNO_HXX
 #define INCLUDED_SC_INC_AFMTUNO_HXX
 
-#include <svl/lstner.hxx>
 #include <svl/itemprop.hxx>
 #include <com/sun/star/lang/XServiceInfo.hpp>
-#include <com/sun/star/container/XContainer.hpp>
-#include <com/sun/star/container/XIndexContainer.hpp>
 #include <com/sun/star/container/XNameReplace.hpp>
-#include <com/sun/star/container/XContainerListener.hpp>
 #include <com/sun/star/container/XSet.hpp>
-#include <com/sun/star/container/ContainerEvent.hpp>
 #include <com/sun/star/container/XIndexReplace.hpp>
 #include <com/sun/star/container/XNameContainer.hpp>
 #include <com/sun/star/container/XNamed.hpp>
 #include <com/sun/star/beans/XPropertySet.hpp>
 #include <com/sun/star/lang/XUnoTunnel.hpp>
-#include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <cppuhelper/implbase.hxx>
 
 class ScAutoFormatFieldObj;
diff --git a/sc/inc/arealink.hxx b/sc/inc/arealink.hxx
index ae503c0a7f2e..cc98b34c3aba 100644
--- a/sc/inc/arealink.hxx
+++ b/sc/inc/arealink.hxx
@@ -24,11 +24,9 @@
 #include "address.hxx"
 #include <sfx2/lnkbase.hxx>
 #include "scdllapi.h"
-#include <memory>
 
 class SfxObjectShell;
 class ScDocShell;
-class Dialog;
 
 class SC_DLLPUBLIC ScAreaLink : public ::sfx2::SvBaseLink, public ScRefreshTimer
 {
diff --git a/sc/inc/attrib.hxx b/sc/inc/attrib.hxx
index 628aae1167d1..d44a7cce4d77 100644
--- a/sc/inc/attrib.hxx
+++ b/sc/inc/attrib.hxx
@@ -27,7 +27,6 @@
 #include <o3tl/typed_flags_set.hxx>
 #include "scdllapi.h"
 #include "global.hxx"
-#include "address.hxx"
 
 // flags for cells hidden by merge
 // and control for auto filter
diff --git a/sc/inc/autonamecache.hxx b/sc/inc/autonamecache.hxx
index 0c6d8421bf79..3be8f87c922a 100644
--- a/sc/inc/autonamecache.hxx
+++ b/sc/inc/autonamecache.hxx
@@ -23,7 +23,6 @@
 #include <unordered_map>
 #include <vector>
 #include "address.hxx"
-#include "global.hxx"
 
 typedef std::vector< ScAddress > ScAutoNameAddresses;
 typedef std::unordered_map< OUString, ScAutoNameAddresses > ScAutoNameHashMap;


More information about the Libreoffice-commits mailing list