[Libreoffice-commits] core.git: extensions/source

Caolán McNamara caolanm at redhat.com
Fri May 11 20:09:27 UTC 2018


 extensions/source/scanner/sanedlg.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 1a3deaa7f7ff1d7e6ab5f5d551bcbc8c00d84052
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Fri May 11 15:35:09 2018 +0100

    coverity#705646 Resource leak
    
    Change-Id: I709b16f720cf97c05207cfb22d0c0ea15622367a
    Reviewed-on: https://gerrit.libreoffice.org/54139
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/extensions/source/scanner/sanedlg.cxx b/extensions/source/scanner/sanedlg.cxx
index f0ea18fa3bdc..f7062a13f283 100644
--- a/extensions/source/scanner/sanedlg.cxx
+++ b/extensions/source/scanner/sanedlg.cxx
@@ -496,7 +496,6 @@ void SaneDlg::InitFields()
                         pField->SetMax( static_cast<long>(pDouble[ nValue-1 ]) );
                     else
                         pField->SetMax( static_cast<long>(pDouble[ 1 ]) );
-                    delete [] pDouble;
                 }
                 switch( i ) {
                     case 0: aMinTopLeft.setX( pField->GetMin() );break;
@@ -514,6 +513,7 @@ void SaneDlg::InitFields()
                     case 3: aMaxBottomRight.setY( static_cast<int>(fValue) );break;
                 }
             }
+            delete [] pDouble;
             pField->Enable();
         }
         else


More information about the Libreoffice-commits mailing list