[Libreoffice-commits] core.git: sw/qa

Luboš Luňák l.lunak at collabora.com
Mon May 14 15:32:19 UTC 2018


 sw/qa/extras/rtfimport/rtfimport.cxx |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 6154d04d90b7b4f68e6c3629bf0c6306ef64a937
Author: Luboš Luňák <l.lunak at collabora.com>
Date:   Tue Apr 24 13:01:22 2018 +0200

    remove page count check in a test (irrelevant and fragile)
    
    If I load this document in LO, either my build or distro build, it has only
    one page, so the test fails for me only because of the 2-page check.
    The commit causing this, b904d639a8, has been in for quite a while,
    so it's apparently something special about my setup, but a) the test
    doesn't actually require 2 pages for anything, b) the commit mentions that
    the test is fragile, c) if I manually inspect the .rtf, there's an extra page
    that I do not see even in Word2013, so the document is possibly a bit broken.
    One way or another, the page check seems pointless.
    
    Change-Id: I18bdf25f71e8eb9225acd667e60f426fca008ee4
    Reviewed-on: https://gerrit.libreoffice.org/53380
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Luboš Luňák <l.lunak at collabora.com>

diff --git a/sw/qa/extras/rtfimport/rtfimport.cxx b/sw/qa/extras/rtfimport/rtfimport.cxx
index 1286d81f7762..10c32eb50c50 100644
--- a/sw/qa/extras/rtfimport/rtfimport.cxx
+++ b/sw/qa/extras/rtfimport/rtfimport.cxx
@@ -1377,9 +1377,6 @@ DECLARE_RTFIMPORT_TEST(testImportHeaderFooter, "tdf108055.rtf")
 
 DECLARE_RTFIMPORT_TEST(testTdf108947, "tdf108947.rtf")
 {
-    //Check page count
-    CPPUNIT_ASSERT_EQUAL(2, getPages());
-
     //Check if Headers/Footers contain what they should in this document
     uno::Reference<text::XText> xHeaderTextRight = getProperty<uno::Reference<text::XText>>(
         getStyles("PageStyles")->getByName("Default Style"), "HeaderTextRight");


More information about the Libreoffice-commits mailing list