[Libreoffice-commits] core.git: extensions/source

Stephan Bergmann sbergman at redhat.com
Tue May 15 07:44:47 UTC 2018


 extensions/source/config/WinUserInfo/WinUserInfoBe.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit bff6751413e918c6e7826a872b6ee24f8302554f
Author: Stephan Bergmann <sbergman at redhat.com>
Date:   Tue May 15 08:23:42 2018 +0200

    loplugin:unnecessaryoverride, loplugin:cstylecast (clang-cl)
    
    Change-Id: I316965219f70a87b59b731e4d5e6b67d2010c2b9
    Reviewed-on: https://gerrit.libreoffice.org/54350
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx b/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
index 3e60716b5cdd..0f39a39b9a27 100644
--- a/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
+++ b/extensions/source/config/WinUserInfo/WinUserInfoBe.cxx
@@ -100,7 +100,7 @@ public:
 
             IADsADSystemInfo* pADsys;
             HRESULT hr = CoCreateInstance(CLSID_ADSystemInfo, nullptr, CLSCTX_INPROC_SERVER,
-                                          IID_IADsADSystemInfo, (void**)&pADsys);
+                                          IID_IADsADSystemInfo, reinterpret_cast<void**>(&pADsys));
             if (FAILED(hr))
                 throw css::uno::RuntimeException();
             CoIfPtr<IADsADSystemInfo> aADsysGuard(pADsys);
@@ -116,7 +116,8 @@ public:
             m_sUserDN = o3tl::toU(sUserDN);
             OUString sLdapUserDN = "LDAP://" + m_sUserDN;
             IADsUser* pUser;
-            hr = ADsGetObject(o3tl::toW(sLdapUserDN.getStr()), IID_IADsUser, (void**)&pUser);
+            hr = ADsGetObject(o3tl::toW(sLdapUserDN.getStr()), IID_IADsUser,
+                              reinterpret_cast<void**>(&pUser));
             if (FAILED(hr))
                 throw css::uno::RuntimeException();
             CoIfPtr<IADsUser> pUserGuard(pUser);
@@ -145,7 +146,6 @@ public:
             GetCachedData(xContext);
         }
     }
-    ~ADsUserAccess() {}
 
     virtual OUString GetGivenName() override { return m_aMap[givenname]; }
     virtual OUString GetSn() override { return m_aMap[sn]; }


More information about the Libreoffice-commits mailing list