[Libreoffice-commits] core.git: sc/inc sc/IwyuFilter_sc.yaml sc/source

Fri May 18 07:21:58 UTC 2018

sc/IwyuFilter_sc.yaml              |   39 +++++++++++++++++++++++++++++++++++++
 sc/inc/fillinfo.hxx                |    2 -
 sc/inc/filter.hxx                  |    1 
 sc/inc/filtuno.hxx                 |    2 -
 sc/inc/fmtuno.hxx                  |    1 
 sc/inc/formulacell.hxx             |    4 ---
 sc/inc/formulagroup.hxx            |    3 --
 sc/inc/formulaopt.hxx              |    2 -
 sc/inc/funcdesc.hxx                |    5 ----
 sc/source/core/tool/formulaopt.cxx |    2 -
 10 files changed, 40 insertions(+), 21 deletions(-)

New commits:
commit 88bbceb7c3ff1560b4ab5caf4b42cd6dfd92b971
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Sat May 12 00:03:20 2018 +0200

    tdf#42949 Fix IWYU warnings in sc/inc/f*
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here
    with minimal fallout management
    
    Change-Id: I5574c9ccac02977c9cde01e24534f82dd9ec82be
    Reviewed-on: https://gerrit.libreoffice.org/54409
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/sc/IwyuFilter_sc.yaml b/sc/IwyuFilter_sc.yaml
index d76f1530a56e..455aabd20da0 100644
--- a/sc/IwyuFilter_sc.yaml
+++ b/sc/IwyuFilter_sc.yaml
@@ -133,3 +133,42 @@ blacklist:
     # base class has to be a complete type
     - com/sun/star/container/XNameReplace.hpp
     - com/sun/star/lang/XServiceInfo.hpp
+    sc/inc/fillinfo.hxx:
+    # base class has to be a complete type
+    - o3tl/typed_flags_set.hxx
+    sc/inc/filtuno.hxx:
+    # base class has to be a complete type
+    - com/sun/star/beans/XPropertyAccess.hpp
+    - com/sun/star/document/XExporter.hpp
+    - com/sun/star/document/XImporter.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/ui/dialogs/XExecutableDialog.hpp
+    sc/inc/fmtuno.hxx:
+    # base class has to be a complete type
+    - com/sun/star/beans/XPropertySet.hpp
+    - com/sun/star/container/XEnumerationAccess.hpp
+    - com/sun/star/container/XNameAccess.hpp
+    - com/sun/star/lang/XUnoTunnel.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/sheet/FormulaToken.hpp
+    - com/sun/star/sheet/XSheetCondition2.hpp
+    - com/sun/star/sheet/XMultiFormulaTokens.hpp
+    - com/sun/star/sheet/XSheetConditionalEntries.hpp
+    - com/sun/star/sheet/XSheetConditionalEntry.hpp
+    sc/inc/fonthelper.hxx:
+    # base class has to be a complete type
+    - tools/color.hxx
+    sc/inc/formulagroup.hxx:
+    # base class has to be a complete type
+    - opencl/platforminfo.hxx
+    sc/inc/formulacell.hxx:
+    # base class has to be a complete type
+    - interpretercontext.hxx
+    sc/inc/formulalogger.hxx:
+    # base class has to be a complete type
+    - memory
+    # needed for conditionally enabled code path
+    - struct ScFormulaCellGroup
+    sc/inc/formulaparserpool.hxx:
+    # base class has to be a complete type
+    - com/sun/star/sheet/XFormulaParser.hpp
diff --git a/sc/inc/fillinfo.hxx b/sc/inc/fillinfo.hxx
index e21a11c9a088..41cac93beae9 100644
--- a/sc/inc/fillinfo.hxx
+++ b/sc/inc/fillinfo.hxx
@@ -25,7 +25,6 @@
 #include <memory>
 
 #include <svx/framelinkarray.hxx>
-#include "global.hxx"
 #include "colorscale.hxx"
 #include "cellvalue.hxx"
 #include <o3tl/typed_flags_set.hxx>
@@ -35,7 +34,6 @@ class SvxBrushItem;
 class SvxBoxItem;
 class SvxLineItem;
 class SvxShadowItem;
-class Color;
 
 class ScPatternAttr;
 
diff --git a/sc/inc/filter.hxx b/sc/inc/filter.hxx
index 11ef4398a701..770d35e91350 100644
--- a/sc/inc/filter.hxx
+++ b/sc/inc/filter.hxx
@@ -22,7 +22,6 @@
 
 #include <rtl/textenc.h>
 #include <rtl/ustring.hxx>
-#include <tools/solar.h>
 #include <vcl/errcode.hxx>
 
 #include "scdllapi.h"
diff --git a/sc/inc/filtuno.hxx b/sc/inc/filtuno.hxx
index 01acc3ccc565..dd6b55950d09 100644
--- a/sc/inc/filtuno.hxx
+++ b/sc/inc/filtuno.hxx
@@ -24,10 +24,8 @@
 #include <com/sun/star/ui/dialogs/XExecutableDialog.hpp>
 #include <com/sun/star/document/XImporter.hpp>
 #include <com/sun/star/document/XExporter.hpp>
-#include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
 #include <cppuhelper/implbase.hxx>
-#include "scdllapi.h"
 
 namespace com { namespace sun { namespace star { namespace io {
     class XInputStream;
diff --git a/sc/inc/fmtuno.hxx b/sc/inc/fmtuno.hxx
index 82e8b9acb445..267828795ecf 100644
--- a/sc/inc/fmtuno.hxx
+++ b/sc/inc/fmtuno.hxx
@@ -43,7 +43,6 @@
 
 class ScDocument;
 class ScTableConditionalEntry;
-class ScConditionalFormat;
 class ScValidationData;
 
 struct ScCondFormatEntryItem
diff --git a/sc/inc/formulacell.hxx b/sc/inc/formulacell.hxx
index 458dc2e10b7c..7656e7a3efec 100644
--- a/sc/inc/formulacell.hxx
+++ b/sc/inc/formulacell.hxx
@@ -20,13 +20,9 @@
 #ifndef INCLUDED_SC_INC_FORMULACELL_HXX
 #define INCLUDED_SC_INC_FORMULACELL_HXX
 
-#include <set>
 #include <memory>
 
 #include <formula/tokenarray.hxx>
-#include <osl/conditn.hxx>
-#include <osl/mutex.hxx>
-#include <rtl/ref.hxx>
 #include <svl/listener.hxx>
 
 #include "types.hxx"
diff --git a/sc/inc/formulagroup.hxx b/sc/inc/formulagroup.hxx
index a02157439448..fa6bb4f61877 100644
--- a/sc/inc/formulagroup.hxx
+++ b/sc/inc/formulagroup.hxx
@@ -17,14 +17,11 @@
 #include "types.hxx"
 #include "stlalgorithm.hxx"
 
-#include <formula/opcode.hxx>
 #if HAVE_FEATURE_OPENCL
 #include <opencl/platforminfo.hxx>
 #endif
-#include <svl/sharedstringpool.hxx>
 
 #include <memory>
-#include <set>
 #include <unordered_map>
 #include <vector>
 
diff --git a/sc/inc/formulaopt.hxx b/sc/inc/formulaopt.hxx
index 49ffdd41e652..14cd9432bef6 100644
--- a/sc/inc/formulaopt.hxx
+++ b/sc/inc/formulaopt.hxx
@@ -13,10 +13,8 @@
 #include <map>
 #include <svl/poolitem.hxx>
 #include <unotools/configitem.hxx>
-#include <unotools/localedatawrapper.hxx>
 #include <formula/grammar.hxx>
 #include "scdllapi.h"
-#include "global.hxx"
 #include "calcconfig.hxx"
 
 class SC_DLLPUBLIC ScFormulaOptions
diff --git a/sc/inc/funcdesc.hxx b/sc/inc/funcdesc.hxx
index 191c3cd488cc..31ad6b0d10e8 100644
--- a/sc/inc/funcdesc.hxx
+++ b/sc/inc/funcdesc.hxx
@@ -33,11 +33,6 @@
 #define MAX_FUNCCAT 12  /* maximum number of categories for functions */
 #define LRU_MAX 10 /* maximal number of last recently used functions */
 
-class ScFuncDesc;
-class ScFunctionList;
-class ScFunctionCategory;
-class ScFunctionMgr;
-
 /**
   Stores and generates human readable descriptions for spreadsheet-functions,
   e.g.\ functions used in formulas in calc
diff --git a/sc/source/core/tool/formulaopt.cxx b/sc/source/core/tool/formulaopt.cxx
index 91c024fd181e..59e297ced427 100644
--- a/sc/source/core/tool/formulaopt.cxx
+++ b/sc/source/core/tool/formulaopt.cxx
@@ -10,7 +10,7 @@
 #include <com/sun/star/uno/Sequence.hxx>
 #include <com/sun/star/lang/Locale.hpp>
 #include <osl/diagnose.h>
-
+#include <unotools/localedatawrapper.hxx>
 #include <formulaopt.hxx>
 #include <miscuno.hxx>
 #include <global.hxx>
