[Libreoffice-commits] core.git: chart2/IwyuFilter_chart2.yaml chart2/source

Gabor Kelemen kelemeng at ubuntu.com
Mon May 28 08:04:24 UTC 2018 

 chart2/IwyuFilter_chart2.yaml                          |   47 ++++++++++++++++-
 chart2/source/model/inc/BaseCoordinateSystem.hxx       |    1 
 chart2/source/model/inc/ChartTypeManager.hxx           |    6 --
 chart2/source/model/inc/DataSeries.hxx                 |    5 -
 chart2/source/model/inc/Diagram.hxx                    |    8 +-
 chart2/source/model/inc/XMLFilter.hxx                  |    7 +-
 chart2/source/model/main/CartesianCoordinateSystem.cxx |    1 
 chart2/source/model/main/DataSeries.cxx                |    1 
 chart2/source/model/main/PolarCoordinateSystem.cxx     |    1 
 9 files changed, 61 insertions(+), 16 deletions(-)

New commits:
commit f50eb2d12e3b80ff75b6d1a89753efcef0cd6f27
Author: Gabor Kelemen <kelemeng at ubuntu.com>
Date:   Mon May 21 18:34:40 2018 +0200

    tdf#42949 Fix IWYU warnings in chart2/source/model/inc/
    
    Found with bin/find-unneeded-includes
    Only removal proposals are dealt with here
    and a bit of fallout management.
    
    Change-Id: I2833ac36c359df76f46e7aa973c012a4d7cedc84
    Reviewed-on: https://gerrit.libreoffice.org/54872
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/chart2/IwyuFilter_chart2.yaml b/chart2/IwyuFilter_chart2.yaml
index 4951d1b1ae46..f826ca6128ac 100644
--- a/chart2/IwyuFilter_chart2.yaml
+++ b/chart2/IwyuFilter_chart2.yaml
@@ -185,4 +185,49 @@ blacklist:
     - com/sun/star/beans/XPropertySet.hpp
     - cppuhelper/propshlp.hxx
     - com/sun/star/beans/XPropertyState.hpp
-
+    chart2/source/model/inc/BaseCoordinateSystem.hxx:
+    # base class has to be a complete type
+    - com/sun/star/chart2/XChartTypeContainer.hpp
+    - com/sun/star/chart2/XCoordinateSystem.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/util/XCloneable.hpp
+    - com/sun/star/util/XModifyBroadcaster.hpp
+    - com/sun/star/util/XModifyListener.hpp
+    chart2/source/model/inc/ChartTypeManager.hxx:
+    # base class has to be a complete type
+    - com/sun/star/chart2/XChartTypeManager.hpp
+    - com/sun/star/lang/XMultiServiceFactory.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    chart2/source/model/inc/DataSeries.hxx:
+    # base class has to be a complete type
+    - com/sun/star/chart2/XDataSeries.hpp
+    - com/sun/star/chart2/XRegressionCurveContainer.hpp
+    - com/sun/star/chart2/data/XDataSink.hpp
+    - com/sun/star/chart2/data/XDataSource.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/util/XCloneable.hpp
+    - com/sun/star/util/XModifyBroadcaster.hpp
+    - com/sun/star/util/XModifyListener.hpp
+    chart2/source/model/inc/Diagram.hxx:
+    # base class has to be a complete type
+    - com/sun/star/chart/X3DDefaultSetter.hpp
+    - com/sun/star/chart2/XCoordinateSystemContainer.hpp
+    - com/sun/star/chart2/XDiagram.hpp
+    - com/sun/star/chart2/XTitled.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
+    - com/sun/star/util/XCloneable.hpp
+    - com/sun/star/util/XModifyBroadcaster.hpp
+    - com/sun/star/util/XModifyListener.hpp
+    chart2/source/model/inc/StockBar.hxx:
+    # base class has to be a complete type
+    - com/sun/star/util/XCloneable.hpp
+    - com/sun/star/util/XModifyBroadcaster.hpp
+    - com/sun/star/util/XModifyListener.hpp
+    chart2/source/model/inc/XMLFilter.hxx:
+    # base class has to be a complete type
+    - com/sun/star/document/XExporter.hpp
+    - com/sun/star/document/XFilter.hpp
+    - com/sun/star/document/XImporter.hpp
+    - com/sun/star/io/XActiveDataSource.hpp
+    - com/sun/star/lang/XMultiServiceFactory.hpp
+    - com/sun/star/lang/XServiceInfo.hpp
diff --git a/chart2/source/model/inc/BaseCoordinateSystem.hxx b/chart2/source/model/inc/BaseCoordinateSystem.hxx
index 76ad85aa597f..1f20e83a02dc 100644
--- a/chart2/source/model/inc/BaseCoordinateSystem.hxx
+++ b/chart2/source/model/inc/BaseCoordinateSystem.hxx
@@ -24,7 +24,6 @@
 #include <cppuhelper/implbase.hxx>
 #include <comphelper/uno3.hxx>
 #include <com/sun/star/lang/XServiceInfo.hpp>
-#include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/chart2/XCoordinateSystem.hpp>
 #include <com/sun/star/chart2/XChartTypeContainer.hpp>
 #include <com/sun/star/util/XCloneable.hpp>
diff --git a/chart2/source/model/inc/ChartTypeManager.hxx b/chart2/source/model/inc/ChartTypeManager.hxx
index 7b09b1a16b7e..dc764ad86c53 100644
--- a/chart2/source/model/inc/ChartTypeManager.hxx
+++ b/chart2/source/model/inc/ChartTypeManager.hxx
@@ -19,15 +19,13 @@
 #ifndef INCLUDED_CHART2_SOURCE_MODEL_INC_CHARTTYPEMANAGER_HXX
 #define INCLUDED_CHART2_SOURCE_MODEL_INC_CHARTTYPEMANAGER_HXX
 
-#include <OPropertySet.hxx>
-#include <MutexContainer.hxx>
 #include <cppuhelper/implbase.hxx>
-#include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
-
 #include <com/sun/star/chart2/XChartTypeManager.hpp>
 
+namespace com { namespace sun { namespace star { namespace uno { class XComponentContext; } } } }
+
 namespace chart
 {
 
diff --git a/chart2/source/model/inc/DataSeries.hxx b/chart2/source/model/inc/DataSeries.hxx
index ee45f584d7b9..aefab3406606 100644
--- a/chart2/source/model/inc/DataSeries.hxx
+++ b/chart2/source/model/inc/DataSeries.hxx
@@ -27,10 +27,7 @@
 #include <com/sun/star/util/XCloneable.hpp>
 #include <com/sun/star/util/XModifyBroadcaster.hpp>
 #include <com/sun/star/util/XModifyListener.hpp>
-#include <com/sun/star/container/XIndexContainer.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
-#include <com/sun/star/beans/XPropertySet.hpp>
-#include <com/sun/star/uno/XComponentContext.hpp>
 
 // helper classes
 #include <cppuhelper/implbase.hxx>
@@ -43,6 +40,8 @@
 #include <MutexContainer.hxx>
 #include <OPropertySet.hxx>
 
+namespace com { namespace sun { namespace star { namespace beans { class XPropertySet; } } } }
+
 namespace chart
 {
 
diff --git a/chart2/source/model/inc/Diagram.hxx b/chart2/source/model/inc/Diagram.hxx
index e622cca202a3..c9690981bfbc 100644
--- a/chart2/source/model/inc/Diagram.hxx
+++ b/chart2/source/model/inc/Diagram.hxx
@@ -23,21 +23,21 @@
 #include <MutexContainer.hxx>
 #include <cppuhelper/implbase.hxx>
 #include <comphelper/uno3.hxx>
-#include <com/sun/star/beans/PropertyValue.hpp>
-#include <com/sun/star/chart2/data/XDataSource.hpp>
 #include <com/sun/star/chart2/XDiagram.hpp>
 #include <com/sun/star/chart2/XCoordinateSystemContainer.hpp>
 #include <com/sun/star/chart2/XTitled.hpp>
 #include <com/sun/star/chart/X3DDefaultSetter.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
-#include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/util/XCloneable.hpp>
 #include <com/sun/star/util/XModifyBroadcaster.hpp>
 #include <com/sun/star/util/XModifyListener.hpp>
 
-#include <map>
 #include <vector>
 
+namespace com { namespace sun { namespace star { namespace beans { struct PropertyValue; } } } }
+namespace com { namespace sun { namespace star { namespace chart2 { namespace data { class XDataSource; } } } } }
+namespace com { namespace sun { namespace star { namespace uno { class XComponentContext; } } } }
+
 namespace chart
 {
 
diff --git a/chart2/source/model/inc/XMLFilter.hxx b/chart2/source/model/inc/XMLFilter.hxx
index 6b97ca858d9e..4f10f1ffbbd4 100644
--- a/chart2/source/model/inc/XMLFilter.hxx
+++ b/chart2/source/model/inc/XMLFilter.hxx
@@ -20,18 +20,19 @@
 #define INCLUDED_CHART2_SOURCE_MODEL_INC_XMLFILTER_HXX
 
 #include <cppuhelper/implbase.hxx>
-#include <com/sun/star/beans/XPropertySet.hpp>
 #include <com/sun/star/document/XFilter.hpp>
 #include <com/sun/star/document/XImporter.hpp>
 #include <com/sun/star/document/XExporter.hpp>
 #include <com/sun/star/lang/XMultiServiceFactory.hpp>
 #include <com/sun/star/lang/XServiceInfo.hpp>
-#include <com/sun/star/uno/XComponentContext.hpp>
 #include <com/sun/star/io/XActiveDataSource.hpp>
-#include <com/sun/star/xml/sax/XWriter.hpp>
 #include <osl/mutex.hxx>
 #include <vcl/errcode.hxx>
 
+namespace com { namespace sun { namespace star { namespace beans { class XPropertySet; } } } }
+namespace com { namespace sun { namespace star { namespace uno { class XComponentContext; } } } }
+namespace com { namespace sun { namespace star { namespace xml { namespace sax { class XWriter; } } } } }
+namespace com { namespace sun { namespace star { namespace lang { class XMultiComponentFactory; } } } }
 
 namespace com { namespace sun { namespace star {
 namespace embed
diff --git a/chart2/source/model/main/CartesianCoordinateSystem.cxx b/chart2/source/model/main/CartesianCoordinateSystem.cxx
index 39d86ff53cb1..c06fbb95766b 100644
--- a/chart2/source/model/main/CartesianCoordinateSystem.cxx
+++ b/chart2/source/model/main/CartesianCoordinateSystem.cxx
@@ -17,6 +17,7 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
+#include <com/sun/star/uno/XComponentContext.hpp>
 #include <CartesianCoordinateSystem.hxx>
 #include <servicenames_coosystems.hxx>
 #include <cppuhelper/supportsservice.hxx>
diff --git a/chart2/source/model/main/DataSeries.cxx b/chart2/source/model/main/DataSeries.cxx
index f24b3c1e0ae8..fb6a41af87f8 100644
--- a/chart2/source/model/main/DataSeries.cxx
+++ b/chart2/source/model/main/DataSeries.cxx
@@ -30,6 +30,7 @@
 #include <EventListenerHelper.hxx>
 #include <com/sun/star/container/NoSuchElementException.hpp>
 #include <com/sun/star/lang/IndexOutOfBoundsException.hpp>
+#include <com/sun/star/uno/XComponentContext.hpp>
 #include <cppuhelper/supportsservice.hxx>
 #include <tools/diagnose_ex.h>
 
diff --git a/chart2/source/model/main/PolarCoordinateSystem.cxx b/chart2/source/model/main/PolarCoordinateSystem.cxx
index 49bede5f2b1b..d84be4322485 100644
--- a/chart2/source/model/main/PolarCoordinateSystem.cxx
+++ b/chart2/source/model/main/PolarCoordinateSystem.cxx
@@ -20,6 +20,7 @@
 #include <PolarCoordinateSystem.hxx>
 #include <servicenames_coosystems.hxx>
 #include <cppuhelper/supportsservice.hxx>
+#include <com/sun/star/uno/XComponentContext.hpp>
 
 using namespace ::com::sun::star;

More information about the Libreoffice-commits mailing list