[Libreoffice-commits] core.git: sfx2/source

Caolán McNamara caolanm at redhat.com
Tue May 29 19:46:55 UTC 2018


 sfx2/source/appl/newhelp.hxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 509df47d2165fd08a7e0d270cade28ff52da532e
Author: Caolán McNamara <caolanm at redhat.com>
Date:   Tue May 29 16:35:27 2018 +0100

    Resolves: tdf#117712 closing help crashes
    
    since...
    
    commit 9fa32e5dce345dea17129587c401c03520fb398b
    Date:   Wed May 16 11:54:52 2018 +0200
    
        fix leak of HelpListener_Impl in SfxHelpWindow_Impl
    
    Change-Id: I7e2cbb5d0c69e96fc7f2e1cc0c5563203c1f3dce
    Reviewed-on: https://gerrit.libreoffice.org/55024
    Tested-by: Jenkins <ci at libreoffice.org>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sfx2/source/appl/newhelp.hxx b/sfx2/source/appl/newhelp.hxx
index ab95c195ec77..133502e6fef8 100644
--- a/sfx2/source/appl/newhelp.hxx
+++ b/sfx2/source/appl/newhelp.hxx
@@ -503,7 +503,7 @@ friend class SfxHelpIndexWindow_Impl;
     VclPtr<SfxHelpIndexWindow_Impl>    pIndexWin;
     VclPtr<SfxHelpTextWindow_Impl>     pTextWin;
     HelpInterceptor_Impl*       pHelpInterceptor;
-    std::unique_ptr<HelpListener_Impl> pHelpListener;
+    rtl::Reference<HelpListener_Impl> pHelpListener;
 
     sal_Int32           nExpandWidth;
     sal_Int32           nCollapseWidth;


More information about the Libreoffice-commits mailing list