[Libreoffice-commits] core.git: svx/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Nov 1 07:33:48 UTC 2018


 svx/source/svdraw/svdhdl.cxx |    5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

New commits:
commit 53bc3b618b5a97702a54d3aa4dbf7853d8980a5d
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Wed Oct 31 16:20:41 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Nov 1 08:33:22 2018 +0100

    tdf#120997 Crash after Ctrl+Tab to traverse points of object, more fix
    
    regression from
        commit b4fc996520b47a6212661a9de3a1c72ccfc379a4
        loplugin:useuniqueptr in SdrHdlList
    
    Change-Id: I53e2adee9a1ad8ef73de5a9601238187a6002241
    Reviewed-on: https://gerrit.libreoffice.org/62714
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/svx/source/svdraw/svdhdl.cxx b/svx/source/svdraw/svdhdl.cxx
index 2c1ee22a064c..7dc05bc1a086 100644
--- a/svx/source/svdraw/svdhdl.cxx
+++ b/svx/source/svdraw/svdhdl.cxx
@@ -2063,10 +2063,9 @@ void SdrHdlList::TravelFocusHdl(bool bForward)
     if(nOldHdlNum != nNewHdlNum)
     {
         mnFocusIndex = nNewHdlNum;
-        SdrHdl* pNew = GetHdl(mnFocusIndex);
-
-        if(pNew)
+        if (mnFocusIndex < GetHdlCount())
         {
+            SdrHdl* pNew = GetHdl(mnFocusIndex);
             pNew->Touch();
         }
     }


More information about the Libreoffice-commits mailing list