[Libreoffice-commits] core.git: sw/source

[Libreoffice Gerrit user]

 sw/source/filter/ww8/docxtablestyleexport.cxx |   10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

New commits:
commit 922f935f9ddefcfc50d0bbf805c97ea3f9d5c5e6
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sun Nov 4 15:51:59 2018 +0000
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Nov 4 22:02:41 2018 +0100

    coverity#1440840 Uninitialized pointer field
    
    Change-Id: I794ec0a173fb20dc0e0d1cf1717a5ad903f9ba7d
    Reviewed-on: https://gerrit.libreoffice.org/62848
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sw/source/filter/ww8/docxtablestyleexport.cxx b/sw/source/filter/ww8/docxtablestyleexport.cxx
index e723c79443a3..3a48ebd2f76a 100644
--- a/sw/source/filter/ww8/docxtablestyleexport.cxx
+++ b/sw/source/filter/ww8/docxtablestyleexport.cxx
@@ -29,14 +29,17 @@ private:
     sax_fastparser::FSHelperPtr m_pSerializer;
 
 public:
+    Impl(SwDoc* pDoc)
+        : m_pDoc(pDoc)
+    {
+    }
+
     void TableStyle(uno::Sequence<beans::PropertyValue>& rStyle);
 
     void setSerializer(sax_fastparser::FSHelperPtr pSerializer) { m_pSerializer = pSerializer; }
 
     sax_fastparser::FSHelperPtr getSerializer() const { return m_pSerializer; }
 
-    void setDoc(SwDoc* pDoc) { m_pDoc = pDoc; }
-
     SwDoc* getDoc() const { return m_pDoc; }
 
     /// Handles a boolean value.
@@ -705,9 +708,8 @@ void DocxTableStyleExport::SetSerializer(const sax_fastparser::FSHelperPtr& pSer
 
 DocxTableStyleExport::DocxTableStyleExport(SwDoc* pDoc,
                                            const sax_fastparser::FSHelperPtr& pSerializer)
-    : m_pImpl(o3tl::make_unique<Impl>())
+    : m_pImpl(o3tl::make_unique<Impl>(pDoc))
 {
-    m_pImpl->setDoc(pDoc);
     m_pImpl->setSerializer(pSerializer);
 }