[Libreoffice-commits] core.git: vcl/qt5

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Nov 8 15:00:01 UTC 2018


 vcl/qt5/Qt5Frame.cxx |    2 --
 1 file changed, 2 deletions(-)

New commits:
commit 97cba40765d3178fecd463879304bac7da0efa59
Author:     Aleksei Nikiforov <darktemplar at basealt.ru>
AuthorDate: Wed Nov 7 15:07:12 2018 +0300
Commit:     Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
CommitDate: Thu Nov 8 15:57:50 2018 +0100

    tdf#120777 KDE5: Remove initial painting of widgets
    
    Widget will be painted later, after correct widget size is set.
    
    If window is not resizeable and painted before setting correct size,
    it saves clipping size in function vcl::Window::ImplIntersectWindowClipRegion
    and never updates it when window is resized to correct size.
    
    This initial painting call causes painting issues in
    "File" -> "Wizard" -> "Letter" dialog:
    "Cancel" button is painted only partially, as well as line above that button.
    
    Other unresizeable windows with width over 640 pixels or height over 480 pixels
    may be affected too.
    
    Change-Id: Ieccb58368670ebbbe6d17826fafc717101309ac4
    Reviewed-on: https://gerrit.libreoffice.org/63017
    Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
    Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>

diff --git a/vcl/qt5/Qt5Frame.cxx b/vcl/qt5/Qt5Frame.cxx
index 70c3de1abcc9..f6428af8b91c 100644
--- a/vcl/qt5/Qt5Frame.cxx
+++ b/vcl/qt5/Qt5Frame.cxx
@@ -187,7 +187,6 @@ void Qt5Frame::InitSvpSalGraphics(SvpSalGraphics* pSvpSalGraphics)
     m_pSvpGraphics->setSurface(m_pSurface.get(), basegfx::B2IVector(width, height));
     cairo_surface_set_user_data(m_pSurface.get(), SvpSalGraphics::getDamageKey(), &m_aDamageHandler,
                                 nullptr);
-    TriggerPaintEvent();
 }
 
 SalGraphics* Qt5Frame::AcquireGraphics()
@@ -213,7 +212,6 @@ SalGraphics* Qt5Frame::AcquireGraphics()
             m_pQt5Graphics.reset(new Qt5Graphics(this));
             m_pQImage.reset(new QImage(m_pQWidget->size(), Qt5_DefaultFormat32));
             m_pQt5Graphics->ChangeQImage(m_pQImage.get());
-            TriggerPaintEvent();
         }
         return m_pQt5Graphics.get();
     }


More information about the Libreoffice-commits mailing list