[Libreoffice-commits] core.git: sal/osl

[Libreoffice Gerrit user]

 sal/osl/w32/file.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 0b34a5dd39e177ba99cd21b639d67ac8123b8458
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sat Nov 10 12:51:57 2018 +0300
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sat Nov 10 12:23:09 2018 +0100

    tdf#120703 PVS: silence a V555
    
    V555 The expression '(curpos - bufpos) > 0' will work as 'curpos != bufpos'.
    
    Change-Id: I432c10c9c5ecc99293ec3f03f6e1a660e1c47e28
    Reviewed-on: https://gerrit.libreoffice.org/63236
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/sal/osl/w32/file.cxx b/sal/osl/w32/file.cxx
index a5e6c640b8ed..1bc898eba4e4 100644
--- a/sal/osl/w32/file.cxx
+++ b/sal/osl/w32/file.cxx
@@ -475,7 +475,7 @@ oslFileError FileHandle_Impl::readLineAt(
         if (curpos >= m_buflen)
         {
             /* buffer examined */
-            if ((curpos - bufpos) > 0)
+            if (curpos > bufpos) // actually, curpos can't become less than bufpos, so != could do
             {
                 /* flush buffer to sequence */
                 result = writeSequence_Impl(