[Libreoffice-commits] core.git: i18npool/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Nov 12 17:19:30 UTC 2018


 i18npool/source/characterclassification/cclass_unicode_parser.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit bc63974e9d82a6ff7954618add266f967fa428eb
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sun Nov 11 23:03:45 2018 +0300
Commit:     Eike Rathke <erack at redhat.com>
CommitDate: Mon Nov 12 18:19:08 2018 +0100

    tdf#120703 PVS: V560 Properly compare current to cDecimalSepAlt
    
    V560 A part of conditional expression is always false: current == cDecimalSep.
    
    Assuming a copypaste error in commit 21052ba2edeef9e16bf90fea62f007b1131c73c0.
    Compare to a similar case below (line 817).
    
    Change-Id: Iebd84aa8df3e37b9a5e4fdc7ce7a25a0704a260f
    Reviewed-on: https://gerrit.libreoffice.org/63269
    Tested-by: Jenkins
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/i18npool/source/characterclassification/cclass_unicode_parser.cxx b/i18npool/source/characterclassification/cclass_unicode_parser.cxx
index 96882a8ef3c2..8cca988607fd 100644
--- a/i18npool/source/characterclassification/cclass_unicode_parser.cxx
+++ b/i18npool/source/characterclassification/cclass_unicode_parser.cxx
@@ -745,7 +745,7 @@ void cclass_Unicode::parseText( ParseResult& r, const OUString& rText, sal_Int32
                         else
                             r.TokenType = KParseType::ASC_NUMBER;
                     }
-                    else if (current == cDecimalSep || (bDecSepAltUsed = (cDecimalSepAlt && current == cDecimalSep)))
+                    else if (current == cDecimalSep || (bDecSepAltUsed = (cDecimalSepAlt && current == cDecimalSepAlt)))
                     {
                         if (nextChar)
                             ++nDecSeps;


More information about the Libreoffice-commits mailing list