[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Nov 13 12:19:10 UTC 2018


 sc/source/core/tool/token.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 3460e91ac853964015215ec75be7cf63361ca0e9
Author:     Luboš Luňák <l.lunak at collabora.com>
AuthorDate: Fri Oct 12 13:42:17 2018 +0200
Commit:     Luboš Luňák <l.lunak at collabora.com>
CommitDate: Tue Nov 13 13:18:44 2018 +0100

    blacklist svExternalName for calc threading
    
    It's the same like svExternal(Single|Double)Ref, there's a lot of thread-unsafe
    code involved.
    
    Change-Id: Ief8bbbd9393788c374215412ee5236ce6bb551fa
    Reviewed-on: https://gerrit.libreoffice.org/63176
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Tested-by: Jenkins

diff --git a/sc/source/core/tool/token.cxx b/sc/source/core/tool/token.cxx
index a7752cf232a2..293b238150aa 100644
--- a/sc/source/core/tool/token.cxx
+++ b/sc/source/core/tool/token.cxx
@@ -1333,6 +1333,7 @@ void ScTokenArray::CheckForThreading( const FormulaToken& r )
         {
             case svExternalDoubleRef:
             case svExternalSingleRef:
+            case svExternalName:
                 SAL_INFO("sc.core.formulagroup", "opcode ocPush: variable type " << StackVarEnumToString(r.GetType())
                     << " disables threaded calculation of formula group");
                 mbThreadingEnabled = false;


More information about the Libreoffice-commits mailing list