[Libreoffice-commits] core.git: reportdesign/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Nov 20 12:11:10 UTC 2018


 reportdesign/source/ui/report/SectionWindow.cxx |    4 ----
 1 file changed, 4 deletions(-)

New commits:
commit a87ba810993a9cd1fd4739d6f42cdc6bc0c82cac
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Nov 19 13:36:01 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Nov 20 13:10:48 2018 +0100

    remove bogus static variable in reportdesign OSectionWindow
    
    which arrived with
       commit bee746960f3d94d92e71006a7365a26669f52f8c
       Date:   Tue Feb 1 13:42:47 2011 +0100
        dba34d: limit invalidate calls
    and looks extremely dodgy, because it means only the very first report
    design window will be correctly configured.
    
    Change-Id: I127c733faaddcacd8507fa74aebe3b6da761327f
    Reviewed-on: https://gerrit.libreoffice.org/63641
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/reportdesign/source/ui/report/SectionWindow.cxx b/reportdesign/source/ui/report/SectionWindow.cxx
index f76f3469ca48..3cc789fea738 100644
--- a/reportdesign/source/ui/report/SectionWindow.cxx
+++ b/reportdesign/source/ui/report/SectionWindow.cxx
@@ -207,13 +207,9 @@ bool OSectionWindow::setGroupSectionTitle(
 
 void OSectionWindow::ImplInitSettings()
 {
-    static bool t = false;
-    if ( t )
-    {
     EnableChildTransparentMode();
     SetParentClipMode( ParentClipMode::NoClip );
     SetPaintTransparent( true );
-    }
     SetBackground( );
 }
 


More information about the Libreoffice-commits mailing list