[Libreoffice-commits] help.git: help3xsl/help.js

[Libreoffice Gerrit user]

 help3xsl/help.js |    7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

New commits:
commit a678c05324cff46eace7c439a4595a3014fa8576
Author:     Ilmari Lauhakangas <ilmari.lauhakangas at libreoffice.org>
AuthorDate: Wed Nov 21 20:42:38 2018 +0200
Commit:     Olivier Hallot <olivier.hallot at libreoffice.org>
CommitDate: Thu Nov 22 16:31:18 2018 +0100

    Stop index headers from being linkified
    
    Change-Id: If445b693feb17fd943eced3a222a20b26039891d
    Reviewed-on: https://gerrit.libreoffice.org/63759
    Tested-by: Jenkins
    Reviewed-by: Jan-Marek Glogowski <glogow at fbihome.de>
    Reviewed-by: Olivier Hallot <olivier.hallot at libreoffice.org>

diff --git a/help3xsl/help.js b/help3xsl/help.js
index 2237ed5b1..e806eeed4 100644
--- a/help3xsl/help.js
+++ b/help3xsl/help.js
@@ -34,8 +34,8 @@ bookmarks.forEach(function(obj) {
         });
 function fullList() {
     document.getElementsByClassName("index")[0].innerHTML = fullLinkified;
-    Paginator(document.getElementsByClassName("index")[0]);
     addIds();
+    Paginator(document.getElementsByClassName("index")[0]);
 }
 // add id to the first items of each category in the index. CSS ::before rule adds the heading text
 function addIds() {
@@ -45,7 +45,8 @@ function addIds() {
     modules.forEach(function(module) {
         var moduleHeader = document.getElementsByClassName(module)[0];
         if (typeof moduleHeader !== 'undefined') {
-            moduleHeader.setAttribute("id", module);
+            // let's wrap the header in a span, so the ::before element will not become a link
+            moduleHeader.outerHTML = '<span id="' + module + '" class="' + module + '">' + moduleHeader.outerHTML + '</span>';
         }
     });
 }
@@ -65,8 +66,8 @@ var filter = function() {
         filtered += '<a href="' + result.obj['url'] + '" class="' + result.obj['app'] + '">' + fuzzysort.highlight(result) + '</a>';
     });
     document.getElementsByClassName("index")[0].innerHTML = filtered;
-    Paginator(document.getElementsByClassName("index")[0]);
     addIds();
+    Paginator(document.getElementsByClassName("index")[0]);
 };
 function debounce(fn, wait) {
     var timeout;