[Libreoffice-commits] core.git: compilerplugins/clang sc/inc sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Nov 23 12:44:45 UTC 2018


 compilerplugins/clang/unusedenumconstants.untouched.results |   28 ------------
 sc/inc/filter.hxx                                           |    3 -
 sc/source/core/inc/doubleref.hxx                            |    2 
 sc/source/ui/inc/autofmt.hxx                                |    2 
 4 files changed, 1 insertion(+), 34 deletions(-)

New commits:
commit 981a98af300eb5247e6ecfb6ec54c590acb54538
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Wed Nov 21 19:17:55 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Fri Nov 23 13:44:17 2018 +0100

    remove some unused enums in sc/
    
    Change-Id: I841f64a8b4f7f9a9e09df3b7877843616129dee1
    Reviewed-on: https://gerrit.libreoffice.org/63755
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/unusedenumconstants.untouched.results b/compilerplugins/clang/unusedenumconstants.untouched.results
index 7404d91512c0..c6810008b394 100644
--- a/compilerplugins/clang/unusedenumconstants.untouched.results
+++ b/compilerplugins/clang/unusedenumconstants.untouched.results
@@ -282,32 +282,12 @@ reportdesign/source/ui/inc/ReportDefines.hxx:24
     enum rptui::DlgEdMode Test
 sax/source/fastparser/fastparser.cxx:80
     enum (anonymous namespace)::CallbackType INVALID
-sc/inc/filter.hxx:43
-    enum ExportFormatLotus ExpWK4
-sc/inc/filter.hxx:43
-    enum ExportFormatLotus ExpWK1
-sc/inc/filter.hxx:43
-    enum ExportFormatLotus ExpWK3
-sc/inc/filter.hxx:44
-    enum ExportFormatExcel ExpBiff4W
-sc/inc/filter.hxx:44
-    enum ExportFormatExcel ExpBiff4
-sc/inc/filter.hxx:44
-    enum ExportFormatExcel ExpBiff3
-sc/inc/filter.hxx:44
-    enum ExportFormatExcel ExpBiff2
-sc/inc/filter.hxx:44
-    enum ExportFormatExcel Exp2007Xml
 sc/inc/scmatrix.hxx:130
     enum ScMatrix::Op Div
 sc/inc/scmatrix.hxx:130
     enum ScMatrix::Op Add
 sc/inc/scmatrix.hxx:130
     enum ScMatrix::Op Sub
-sc/source/core/inc/doubleref.hxx:41
-    enum ScDBRangeBase::RefType EXTERNAL
-sc/source/core/inc/doubleref.hxx:41
-    enum ScDBRangeBase::RefType INTERNAL
 sc/source/filter/excel/xiescher.cxx:460
     enum (anonymous at /home/noel/libo2/sc/source/filter/excel/xiescher.cxx:460:17) eCreateFromOffice
 sc/source/filter/inc/decl.h:24
@@ -316,14 +296,6 @@ sc/source/ui/inc/anyrefdg.hxx:192
     enum ScRefHdlrImpl<class ScValidationDlg, class SfxTabDialog, false>::(anonymous at /home/noel/libo2/sc/source/ui/inc/anyrefdg.hxx:192:5) SLOTID
 sc/source/ui/inc/anyrefdg.hxx:192
     enum ScRefHdlrImpl::(anonymous at /home/noel/libo2/sc/source/ui/inc/anyrefdg.hxx:192:5) SLOTID
-sc/source/ui/inc/autofmt.hxx:33
-    enum AutoFmtLine BOTTOM_LINE
-sc/source/ui/inc/autofmt.hxx:33
-    enum AutoFmtLine LEFT_LINE
-sc/source/ui/inc/autofmt.hxx:33
-    enum AutoFmtLine RIGHT_LINE
-sc/source/ui/inc/autofmt.hxx:33
-    enum AutoFmtLine TOP_LINE
 sc/source/ui/StatisticsDialogs/RegressionDialog.cxx:105
     enum (anonymous namespace)::ScRegType LINEAR
 svx/inc/sxmkitm.hxx:25
diff --git a/sc/inc/filter.hxx b/sc/inc/filter.hxx
index 3739a0ec1953..f9201d01951c 100644
--- a/sc/inc/filter.hxx
+++ b/sc/inc/filter.hxx
@@ -40,8 +40,7 @@ class ScOrcusFilters;
 enum EXCIMPFORMAT { EIF_AUTO, EIF_BIFF5, EIF_BIFF8, EIF_BIFF_LE4 };
 
 // for export
-enum ExportFormatLotus { ExpWK1, ExpWK3, ExpWK4 };
-enum ExportFormatExcel { ExpBiff2, ExpBiff3, ExpBiff4, ExpBiff4W, ExpBiff5, ExpBiff8, Exp2007Xml };
+enum ExportFormatExcel { ExpBiff5, ExpBiff8 };
 
 // These are implemented inside the scfilt library and lazy loaded
 
diff --git a/sc/source/core/inc/doubleref.hxx b/sc/source/core/inc/doubleref.hxx
index 7786104e8de2..bd35b7d905e1 100644
--- a/sc/source/core/inc/doubleref.hxx
+++ b/sc/source/core/inc/doubleref.hxx
@@ -38,8 +38,6 @@ enum class FormulaError : sal_uInt16;
 class ScDBRangeBase
 {
 public:
-    enum RefType { INTERNAL, EXTERNAL }; // TODO: We may not need this after all... (kohei)
-
     ScDBRangeBase() = delete;
 
     virtual ~ScDBRangeBase() = 0;
diff --git a/sc/source/ui/inc/autofmt.hxx b/sc/source/ui/inc/autofmt.hxx
index ecd89380def8..2a650ef77223 100644
--- a/sc/source/ui/inc/autofmt.hxx
+++ b/sc/source/ui/inc/autofmt.hxx
@@ -30,8 +30,6 @@ class SvNumberFormatter;
 class VirtualDevice;
 class ScViewData;
 
-enum AutoFmtLine { TOP_LINE, BOTTOM_LINE, LEFT_LINE, RIGHT_LINE };
-
 class SC_DLLPUBLIC ScAutoFmtPreview : public vcl::Window
 {
 public:


More information about the Libreoffice-commits mailing list