[Libreoffice-commits] core.git: sc/source
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Thu Oct 4 17:08:38 UTC 2018
sc/source/core/tool/chartpos.cxx | 1 -
1 file changed, 1 deletion(-)
New commits:
commit cc354c104e09a2f35faf06a3df9d044ced94d6a9
Author: Eike Rathke <erack at redhat.com>
AuthorDate: Thu Oct 4 19:06:34 2018 +0200
Commit: Eike Rathke <erack at redhat.com>
CommitDate: Thu Oct 4 19:08:14 2018 +0200
Resolves: tdf#120238 remove wrong assert()
There may be a non-empty RowMap even if
nColCount == 0 || nRowCount == 0
if there was only one column or row (or cell) selected and
bRowHeaders and/or bColHeaders were set, thus nColCount and/or
nRowCount were decremented by 1.
Regression from
commit b1f9aa5f58ea322097998839e00d95fc40be8b22
CommitDate: Fri Sep 28 09:04:07 2018 +0200
loplugin:useuniqueptr in ScChartPositionMap
Change-Id: I942e3fcc92449da57d708f654000387f862a4066
diff --git a/sc/source/core/tool/chartpos.cxx b/sc/source/core/tool/chartpos.cxx
index be4a515db9eb..d92a891481b3 100644
--- a/sc/source/core/tool/chartpos.cxx
+++ b/sc/source/core/tool/chartpos.cxx
@@ -406,7 +406,6 @@ void ScChartPositioner::CreatePositionMap()
{ // create an entry without data
RowMap& rCol = aColMap[0];
nColCount = 1;
- assert ( rCol.empty() );
rCol[ 0 ] = nullptr;
nRowCount = 1;
nColAdd = 0;
More information about the Libreoffice-commits
mailing list